Add splitting of slash-separated titles - #75
Conversation
|
Thanks for the PR, i'll look at it this weekend. |
|
Hi Lucas. It's been a long time since this pull request was made :) Are there any problems with it? Maybe I should add some changes to keep up with current newspaper code? |
|
Hey Igor! Thanks for the reminder. Hmm, have you considered the case where you'd need to split the title by I think it would be better if you'd change line: This is because I'm just being nitty, but I want to know your thoughts. |
|
Yeah, I think you're right. All the examples I initially saw had that sandwiching, and I wanted to avoid splitting by slashes that are part of a title text, that's why I added that spaces. Now it seems to me that it should be a rare case, so it would be better to remove them. That way we can also split titles with double slashes (which sometimes occur). So, thanks for the correction, I'll fix it. |
|
Nice work 👍 |
No description provided.