Skip to content

split title with _ - #87

Merged
codelucas merged 1 commit into
codelucas:masterfrom
deweydu:master
Nov 19, 2014
Merged

split title with _ #87
codelucas merged 1 commit into
codelucas:masterfrom
deweydu:master

Conversation

@deweydu

@deweydu deweydu commented Nov 17, 2014

Copy link
Copy Markdown
  1. I found some sites contained underscore in title section, so I think we add split title with undersocre for good.
  2. Usually, we just want to download one category, instead of all categories.

@deweydu deweydu changed the title split title with _ split title with _ and set limited categories Nov 17, 2014
@codelucas

Copy link
Copy Markdown
Owner

I like your title splitting by underscore change but I don't understand the category change.

Usually, we just want to download one category, instead of all categories.

How do you know that? Could you update this PR to remove that commit?

@deweydu deweydu changed the title split title with _ and set limited categories split title with _ Nov 19, 2014
@deweydu

deweydu commented Nov 19, 2014

Copy link
Copy Markdown
Author

Hi Lucas,

I have remove that commit, and left the title splitting by underscore.

Thanks :)

@codelucas

Copy link
Copy Markdown
Owner

👍

codelucas added a commit that referenced this pull request Nov 19, 2014
@codelucas
codelucas merged commit 493a8a7 into codelucas:master Nov 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants