Allow forwarding ports via URL #1309

Activity

1. nhooyr

   added

   enhancementSome improvement that isn't a featureSome improvement that isn't a feature

   on Jan 28, 2020
2. Rekrii commented on Jan 28, 2020

   

   Rekrii

   on Jan 28, 2020

   More actions

   Currently I do this via a reverse proxy (nginx or similar) on the host box to forward /8080 URL to :8080 the code-server instance, and then an nginx server in CS to host whatever the user (me) wants. Very neat and simple. Not sure how scaleable it is if you needed 10k+ ports.

   Comes down to if CS needs to be a swiss army knife of tools, or just a base IDE and you add stuff yourself (e.g. nginx as above).
3. sr229 commented on Jan 28, 2020

   

   sr229

   on Jan 28, 2020

   Contributor

   More actions

   I think we'll have a lot of benefits having a port forwarding proxy since its been a long overdue request by the community for us. Though I'd prefer we do it as a VS Code extension since its more suitable to do it in VS Code's own APIs AFAIK.
4. nhooyr

   added

   needs-decision

   on Jan 29, 2020
5. zhpengfei commented on Feb 15, 2020

   

   zhpengfei

   on Feb 15, 2020

   Last edited by zhpengfei

   More actions

   @Rekrii Could you share the contents of the nginx.conf ? Thanks very much!
6. Rekrii commented on Feb 25, 2020

   

   Rekrii

   on Feb 25, 2020

   Last edited by Rekrii

   More actions

   @zpfei206 Sorry I was on holiday. See below:

   I use something simple like this in an nginx instance running in code-server:

   server {
   listen 8080;
   server_name my.domain.com;
   root /config/workspace/MyProjectHTMLFiles/;
   index index.html;
   }

   On the nginx reverse proxy i use:

   location /8080/ {
   proxy_pass http://localhost:8080/;
   proxy_http_version 1.1;
   proxy_set_header Upgrade $http_upgrade;
   proxy_set_header Connection "upgrade";
   }

   This way i forward a single port, 80, to my nginx RP, and it can then do basic-auth where i need (for my code-server instance) and have it hand connections to different ports internally.

   Also ensure all SSL config is secure; ciphers, etc are good (I use Qualsys SSL Labs test).

   As i mentioned above, this won't scale too well into a large number of ports. But I use this to test/host different prototype projects I'm working on - normally say 10 or so, so i can manually do this port forward setup for such a small number.
7. benz0li commented on Mar 27, 2020

   

   benz0li

   on Mar 27, 2020

   Contributor

   More actions

   @Rekrii You might consider

   location ~ /(\d+)/(.*) {
     proxy_pass http://localhost:$1/$2;
     proxy_http_version 1.1;
     proxy_set_header Upgrade $http_upgrade;
     proxy_set_header Connection "upgrade";
   }
   

   for general port forwarding.
8. kylecarbs commented on Mar 27, 2020

   

   kylecarbs

   on Mar 27, 2020

   Member

   More actions

   Fixed once #1453 is merged.
9. benz0li commented on Mar 27, 2020

   

   benz0li

   on Mar 27, 2020

   Last edited by benz0li

   Contributor

   More actions

   @code-asher Thanks for the great work on #1453.

   I think /p/<number> would be preferable to <number>.[domain] as it remained compatibility running Code Server on Jupyter using Jupyter Server Proxy.
10. code-asher commented on Mar 27, 2020

    

    code-asher

    on Mar 27, 2020

    Member

    More actions

    @benz0li Thanks! I didn't mention it in the PR but /proxy/<number> will also work.

    👍React with 👍4Reacted by Olivier Benz, Kyle Carberry, Leo Hui and Nzix

    🎉React with 🎉2Reacted by Olivier Benz and Kyle Carberry
11. Rekrii commented on Mar 28, 2020

    

    Rekrii

    on Mar 28, 2020

    More actions

    @benz0li oh that's much cleaner - thanks!
12. kylecarbs commented on Apr 14, 2020

    

    kylecarbs

    on Apr 14, 2020

    Member

    More actions

    It's been merged 🎊
13. kylecarbs

    closed this as completedon Apr 14, 2020