Persistant terminal session on tab refresh #2276

Activity

1. bpmct

   added

   feature

   on Nov 6, 2020
2. ntimo commented on Nov 9, 2020

   

   ntimo

   on Nov 9, 2020

   More actions

   VSCode 1.51 has been released with support for "Ability to persist/reconnect to terminal sessions." might this actually fix this issue?

   Source: https://code.visualstudio.com/updates/v1_51
3. code-asher commented on Nov 9, 2020

   

   code-asher

   on Nov 9, 2020 via email

   Member

   More actions

   Yes, I'm pretty sure it should! Will be working on this update soon.

   🚀React with 🚀4Reacted by Ben Potter, Martin Buchleitner, Stuart P. Bentley and Hans-Georg Winkler
4. code-asher

   self-assigned this

   on Nov 9, 2020
5. ntimo commented on Nov 20, 2020

   

   ntimo

   on Nov 20, 2020

   More actions

   I just installed code server v3.7.2 which contains the update to vscode 1.51 but sadly the terminal sessions are not persistent :(
6. code-asher commented on Nov 20, 2020

   

   code-asher

   on Nov 20, 2020 via email

   Member

   More actions

   Sorry about that, we still need to implement the persistence. I have it partially implemented but it doesn't work for things like htop or vim.
7. nhooyr

   added

   enhancementSome improvement that isn't a featureSome improvement that isn't a feature

   featureNew user visible featureNew user visible feature

   and removed

   feature

   enhancementSome improvement that isn't a featureSome improvement that isn't a feature

   on Dec 7, 2020
8. nhooyr

   unassigned

   code-asher

   on Dec 8, 2020
9. outermeasure commented on Feb 11, 2021

   

   outermeasure

   on Feb 11, 2021

   Contributor

   More actions

   Any news on this? @code-asher Do you have a starting point so I can take a look?
10. code-asher commented on Feb 12, 2021

    

    code-asher

    on Feb 12, 2021 via email

    Member

    More actions

    No updates. The code is all in https://github.com/cdr/code-server/blob/v3.8.1/lib/vscode/src/vs/server/node/channel.ts. Here is where we force persistence off until we fix it: https://github.com/cdr/code-server/blob/v3.8.1/lib/vscode/src/vs/server/node/channel.ts#L569 This is the code that tries to store the data: https://github.com/cdr/code-server/blob/v3.8.1/lib/vscode/src/vs/server/node/channel.ts#L506-L543 And the code that tries to restore it: https://github.com/cdr/code-server/blob/v3.8.1/lib/vscode/src/vs/server/node/channel.ts#L480-L488 It works for simple text printed to the terminal but it falls apart with things like htop, vim, etc.

    👍React with 👍2Reacted by Adrian Soucup and Stillward
11. outermeasure commented on Feb 12, 2021

    

    outermeasure

    on Feb 12, 2021

    Contributor

    More actions

    Thank you. I will send a PR if I get anywhere (but no promises).

    👍React with 👍1Reacted by Ben Potter
12. outermeasure commented on Feb 12, 2021

    

    outermeasure

    on Feb 12, 2021

    Contributor

    More actions

    Ok, I found a related but different problem that was a bit more irritating. Terminal processes leak when refreshing the page.
    I have a PR for that: #2723
13. ntimo commented on Mar 25, 2021

    

    ntimo

    on Mar 25, 2021

    More actions

    @outermeasure @code-asher Do you have any news about this? :) This would be super important since for example when your run Ansible from Code Server and your connection for what ever reason breaks being able to reconnect and still having the open terminal would be quite nice.
14. code-asher commented on Mar 26, 2021

    

    code-asher

    on Mar 26, 2021

    Member

    More actions

    Nope, we haven't done anything here yet.
15. jsjoeio

    added this to the Backlog milestone on Apr 29, 2021
16. code-asher

    added a commit that references this issue on May 7, 2021

    Use ptyHostService

    ...

    This issue will close once commit 6d1da2c is merged into the 'master' branch.

    6d1da2c
17. code-asher

    modified the milestones: Backlog, v3.9.4 on May 7, 2021
18. code-asher

    added a commit that references this issue on May 7, 2021

    Use ptyHostService

    ...

    This issue will close once commit c416e9b is merged into the 'master' branch.

    c416e9b
19. code-asher

    closed this as completedin #3308on May 7, 2021
20. raychunghk commented on Apr 30, 2024

    

    raychunghk

    on Apr 30, 2024

    More actions

    Now i use control+shift+p , then "Terminal: Attach to Session" to resume the terminal session I was working on.