You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed the yarn package version is still 3.9.1
Is it forgotten or was there an issue with the update?
In the past the update on there was more or less in sync with the GitHub releases.
Perhaps we should change it so it's triggered by yarn registry instead
Yeah that could be safer. Though we are working on improving our CI flow! This release today has showed the process is more fragile than it should be 😅
Oh, this is interesting! I noticed that it affects your install script as well, but I am not sure if it is related. We build an image with code-server with a reverse proxy and I noticed it kept building with version 3.9.1. I was able to work around it by passing --version 3.9.2 to forcefully install the new version.
Heads-up: we're still running into issues with our publish workflow and scripts. We will continue looking into this first thing tomorrow.
Thanks for the heads up. We changed the trigger to check the yarn registry instead so we don't have hourly failing builds anymore. Once you fix your pipeline and push to yarn, our ci should pick it up.
Activity
jsjoeio commentedon Mar 25, 2021
Thanks for being so quick to notice @aptalca! Yes, when we released
3.9.2something broke in ourpublishworkflow: https://github.com/cdr/code-server/actions/runs/688144994Once #2968 passes and we merge it, I'm going to trigger a manual publish, which should publish the new version to
npm, etc.aptalca commentedon Mar 26, 2021
I wish I could take credit 😅 Our ci notified me: https://ci.linuxserver.io/blue/organizations/jenkins/Docker-Pipeline-Builders%2Fdocker-code-server/detail/master/218/pipeline
It is triggered by GitHub releases but uses yarn to install. Perhaps we should change it so it's triggered by yarn registry instead.
jsjoeio commentedon Mar 26, 2021
Woah! Super cool that y'all have that set up.
Yeah that could be safer. Though we are working on improving our CI flow! This release today has showed the process is more fragile than it should be 😅
jsjoeio commentedon Mar 26, 2021
Heads-up: we're still running into issues with our publish workflow and scripts. We will continue looking into this first thing tomorrow.
PatrickDerichs commentedon Mar 26, 2021
Oh, this is interesting! I noticed that it affects your install script as well, but I am not sure if it is related. We build an image with code-server with a reverse proxy and I noticed it kept building with version 3.9.1. I was able to work around it by passing
--version 3.9.2to forcefully install the new version.jsjoeio commentedon Mar 26, 2021
Interesting! Thanks for the report @PatrickDerichs - we'll have to confirm once we get this fixed if that's a bug as well.
aptalca commentedon Mar 26, 2021
Thanks for the heads up. We changed the trigger to check the yarn registry instead so we don't have hourly failing builds anymore. Once you fix your pipeline and push to yarn, our ci should pick it up.
Thanks
jsjoeio commentedon Mar 26, 2021
The issue has been resolved and
3.9.2is now available on the npm registry.We've also written a regression report which you can read here: #2983