Skip to content

Fix settings sync login and "loading" text #3418

Closed as not planned
Closed as not planned

Description

@code-asher

Currently if you hover over the account login when you aren't logged in it just says "loading".

This is what it should look like instead:

Pressing "turn on settings sync" then takes you through the login process. It allows you to sign in with Microsoft and GitHub although I'm not sure we'll be able to support both or only GitHub.


If you are already logged in (to GitHub) supposedly syncing works and the icon works fine too but we should verify this.


Previous issues: #2587 #2913

Activity

  1. added this to the 3.11.0 milestone on May 19, 2021
  2. code-asher commented on May 19, 2021

    @code-asher
    MemberAuthor

    Interestingly if you have the GitHub pull request extension installed the icon works but there is still no sync.

    After poking around it seems that settings sync is intentionally not included in the OSS.

    So we'll still want to have the "you are not signed in" verbiage when you aren't signed in and there are no extensions providing auth but we won't have the "turn on settings sync" option.

    And then at a later date perhaps we can look into implementing sync.

  3. modified the milestones: 3.10.2, 3.11.0 on May 21, 2021
  4. modified the milestones: 3.11.0, 3.12.0 on Jul 19, 2021
  5. johnsonw commented on Jul 29, 2021

    @johnsonw

    After poking around it seems that settings sync is intentionally not included in the OSS.
    Any particular reason? My VS Code local install shows it here:
    image

    But when I go to the remote container it's missing as you said:
    image

    Just wondering why this would be intentional?

  6. code-asher commented on Jul 29, 2021

    @code-asher
    MemberAuthor
  7. modified the milestones: 3.12.0, On Deck on Aug 11, 2021
  8. stale commented on Feb 7, 2022

    @stale

    This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no activity occurs in the next 5 days.

  9. tsndr commented on Mar 20, 2022

    @tsndr

    I'm still having this issue.

  10. 5 remaining items

  11. emielvangoor commented on May 18, 2022

    @emielvangoor

    Same here...

    I use WSL2 Ubuntu. I install git on the WSL Ubuntu from terminal, then the problem solved.

    i'm using Mac OS Monterey. I've moved away from code-server, i never managed to fix this unfortunately.

  12. norbertjoni commented on May 19, 2022

    @norbertjoni

    same issue from chromebook

  13. changed the title [-]Fix settings sync login[/-] [+]Fix settings sync login and "loading" text[/+] on Jun 22, 2022
  14. Sharpz7 commented on Jun 22, 2022

    @Sharpz7

    @jsjoeio It worked for me for ages and suddenly broke (i.e worked in march broke on the 21st June). This issue doesn't seem to cover that context?

  15. jsjoeio commented on Jun 22, 2022

    @jsjoeio
    Contributor

    @Sharpz7 interesting...it's never worked for me. When you say "cover that context", what are you referring to?

  16. Sharpz7 commented on Jun 22, 2022

    @Sharpz7

    Sorry, after more extensive testing it seems that Copilot had a login system change on the same day as this started, so is just a co-incidence. I apoligize ;)

  17. jsjoeio commented on Jun 23, 2022

    @jsjoeio
    Contributor

    Ahhhh interesting! Thanks for confirming. No worries! 😄

  18. nmcc1212 commented on Nov 11, 2022

    @nmcc1212

    how does https://github.dev achive using settings sync?

  19. code-asher commented on Nov 14, 2022

    @code-asher
    MemberAuthor
  20. bitdruid commented on Jan 20, 2023

    @bitdruid

    if you may have noticed all microsoft extensions are missing in the oss version. thats why i uninstalled it after short testing about a year ago as i'm using a lot of them and setting-sync would be useless if half of my extensions are missing.

    there is currently no workaround as long as there is no version like ,,bin-server"

  21. sunerpy commented on Mar 29, 2023

    @sunerpy

    same issue
    When I pressed "turn on settings sync" ,there is nothing happened...
    I run code-server with docker, any ideas to help me login?

  22. dnslin commented on Apr 30, 2023

    @dnslin

    docker latest
    So how do we solve this problem

  23. cpatrickalves commented on Jul 31, 2023

    @cpatrickalves

    Any update about this?
    I am running code-server on Kubernetes.

    image

  24. code-asher commented on Jul 31, 2023

    @code-asher
    MemberAuthor

    It looks like upstream changed "loading" to "no accounts requested yet..." so I think we can consider that portion of the issue resolved.

    And for the settings sync portion we have another issue tracking that (#2195) so I will close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions