Skip to content

Run extensions in production mode  #4219

Closed
Closed
Run extensions in production mode #4219
Labels
bugSomething isn't workinghigh-priorityThis issue needs to be resolved ASAP
Milestone
4.0.1

Description

@jsjoeio
jsjoeio
opened on Sep 21, 2021

ExtensionContext.extensionMode (passed to activate) is set to ExtensionMode.Development (integer value of 2) instead of Production. In other words, code-server runs extensions in non-production mode, which my extension took as a sign to enable that devserver shortcut. Not really a problem, if it weren't for the next problem

@SchoofsKelvin

Originally posted: #4075 (reply in thread)

Related: SchoofsKelvin/vscode-sshfs#279

Activity

  1. jsjoeio
    added
    bugSomething isn't working
    on Sep 21, 2021
  2. jsjoeio
    added this to the On Deck milestone on Sep 21, 2021

  3. jsjoeio commented on Sep 21, 2021

    @jsjoeio
    jsjoeio
    on Sep 21, 2021
    ContributorAuthor

    cc @TeffenEllis (I figured you would find this interesting! Probably something we did a long time ago if I had to guess?)

  4. benz0li commented on Sep 28, 2021

    @benz0li
    benz0li
    on Sep 28, 2021
    Contributor

    Related: REditorSupport/vscode-R#275 (comment)

  5. jsjoeio
    added
    high-priorityThis issue needs to be resolved ASAP
    on Sep 29, 2021
  6. jsjoeio
    modified the milestones: On Deck, 3.12.2 - improve iPad UX on Sep 29, 2021

  7. tianjianchnbytedance commented on Oct 19, 2021

    @tianjianchnbytedance
    tianjianchnbytedance
    on Oct 19, 2021

    @jsjoeio So may I ask you that why did we set the extensionMode to development?

  8. jsjoeio commented on Oct 28, 2021

    @jsjoeio
    jsjoeio
    on Oct 28, 2021
    ContributorAuthor

    @tianjianchnbytedance I wish I could tell you - that's before my time! Probably a goof on our end when adding our VS Code fork to code-server. Should be an easy fix though.

  9. benz0li commented on Dec 11, 2021

    @benz0li
    benz0li
    on Dec 11, 2021
    Contributor

    This issue seems to be resolved with v4.0.0.

  10. jsjoeio commented on Dec 13, 2021

    @jsjoeio
    jsjoeio
    on Dec 13, 2021
    ContributorAuthor

    Woohoo! Thank you for confirming @benz0li

    I'll close this for now then.

  11. jsjoeio
    closed this as completedon Dec 13, 2021
  12. jsjoeio
    modified the milestones: 4.1.0 - improve iPad UX, 4.0.0 on Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinghigh-priorityThis issue needs to be resolved ASAP

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions