Repository navigation
[Bug]: code-server version not respected when installing extensions using CLI #5031
Description
Is there an existing issue for this?
- I have searched the existing issues
OS/Web Information
- Web Browser: Safari 15.4
- Local OS: macOS 12.3 (Monterey)
- Remote OS: Debian bullseye
- Remote Architecture: amd64
code-server --version: 4.2.0 693b1fa with Code 1.64.2
Steps to Reproduce
- Open code-server
- Install extension Jupyter
- Check version
Expected
2022.2.1010641114
Actual
2022.3.1000901801
Logs
No response
Screenshot/Video
No response
Does this issue happen in VS Code?
- I cannot reproduce this in VS Code.
Are you accessing code-server over HTTPS?
- I am using HTTPS.
Notes
No response
Activity
benz0li commentedon Mar 25, 2022
Most probably related to eclipse-openvsx/openvsx#436.
benz0li commentedon Mar 25, 2022
Further references:
Previewbadge eclipse-openvsx/openvsx#423jsjoeio commentedon Mar 25, 2022
Oh wow, nice find! Subscribing to the eclipse issue you opened.
benz0li commentedon Mar 29, 2022
For the time being, it is best to pin the version of this extension, e.g.
code-server --install-extension ms-toolsai.jupyter@2022.2.1010641114.ℹ️ See EclipseFdn/publish-extensions#569 (comment) ff.
Not an issue of code-server.
[-][Bug]: Are pre-release versions of extensions installed by default?[/-][+][Bug]: code-server version not respected when installing extensions[/+]benz0li commentedon Apr 15, 2022
It seems to be an issue of code-server.
Executing
results in
But v2022.3.1000901801 of ms-toolsai.jupyter is neither compatible with code-server 4.2.0 (Code 1.64.2) nor code-server 4.3.0 (Code 1.65.2):
{ "extensions": [ { "namespaceUrl": "https://open-vsx.org/api/ms-toolsai", "reviewsUrl": "https://open-vsx.org/api/ms-toolsai/jupyter/reviews", "files": { "download": "https://open-vsx.org/api/ms-toolsai/jupyter/2022.3.1000901801/file/ms-toolsai.jupyter-2022.3.1000901801.vsix", "manifest": "https://open-vsx.org/api/ms-toolsai/jupyter/2022.3.1000901801/file/package.json", "readme": "https://open-vsx.org/api/ms-toolsai/jupyter/2022.3.1000901801/file/README.md", "changelog": "https://open-vsx.org/api/ms-toolsai/jupyter/2022.3.1000901801/file/CHANGELOG.md", "license": "https://open-vsx.org/api/ms-toolsai/jupyter/2022.3.1000901801/file/LICENSE.txt", "icon": "https://open-vsx.org/api/ms-toolsai/jupyter/2022.3.1000901801/file/icon.png" }, "name": "jupyter", "namespace": "ms-toolsai", "version": "2022.3.1000901801", "publishedBy": { "loginName": "open-vsx", "fullName": "Open VSX", "avatarUrl": "https://avatars0.githubusercontent.com/u/61870837?v=4", "homepage": "https://github.com/open-vsx", "provider": "github" }, "verified": false, "unrelatedPublisher": true, "namespaceAccess": "restricted", "allVersions": { "latest": "https://open-vsx.org/api/ms-toolsai/jupyter/latest", "2022.3.1000901801": "https://open-vsx.org/api/ms-toolsai/jupyter/2022.3.1000901801" }, "averageRating": 5, "downloadCount": 140513, "reviewCount": 1, "versionAlias": [ "latest" ], "timestamp": "2022-03-29T20:55:43.309137Z", "preview": false, "displayName": "Jupyter", "description": "Jupyter notebook support, interactive programming and computing that supports Intellisense, debugging and more.", "engines": { "vscode": "^1.66.0" }, "categories": [ "Programming Languages", "Other", "Extension Packs", "Data Science", "Machine Learning", "Notebooks", "Visualization" ], "extensionKind": [ "workspace" ], "tags": [ "__ext_jl", "debuggers", "ipynb", "julia", "jupyter", "keybindings", "multi-root ready", "notebook", "notebookKernelJupyterNotebook", "python", "raw" ], "license": "MIT", "homepage": "https://github.com/Microsoft/vscode-jupyter", "repository": "https://github.com/Microsoft/vscode-jupyter.git", "bugs": "https://github.com/Microsoft/vscode-jupyter/issues", "galleryColor": "#ffffff", "galleryTheme": "light", "qna": "https://github.com/microsoft/vscode-jupyter/discussions", "dependencies": [], "bundledExtensions": [ { "url": "https://open-vsx.org/api/ms-toolsai/jupyter-keymap", "namespace": "ms-toolsai", "extension": "jupyter-keymap" }, { "url": "https://open-vsx.org/api/ms-toolsai/jupyter-renderers", "namespace": "ms-toolsai", "extension": "jupyter-renderers" } ] } ] }👉 v2022.3.1000901801 of ms-toolsai.jupyter is only compatible with Code 1.66.0 and later.
benz0li commentedon Apr 15, 2022
FYI @fritterhoff
jsjoeio commentedon Apr 15, 2022
@benz0li thank you for the detailed notes/logs! So the extension installs even when it shouldn't. Does it show up in the Extensions panel and does it work?
10 remaining items
benz0li commentedon Jun 24, 2022
If considered an issue, this is upstream (microsoft/vscode). On a Machine (arch:
x86_64) running docker:Within the container:
useradd -ms /bin/bash coder \ && su - coderExecuting
results in
👉 v2022.5.1001601848 of ms-toolsai.jupyter is not compatible with Code 1.65.2.
benz0li commentedon Jun 24, 2022
I'm going to check at https://github.com/microsoft/vscode/issues if someone already filed an issue.
jsjoeio commentedon Jun 24, 2022
Nice find! So it does sound like it's upstream. Let us know what you find! Otherwise, we may be able to patch it on our side. At least, we'll have an easy way to run integration tests once #5275 is merged.
benz0li commentedon Jun 25, 2022
Cross reference: microsoft/vscode#153201
benz0li commentedon Jul 22, 2022
There was some back and forth at microsoft/vscode#153201 but microsoft/vscode#153201 (comment) will lead to an answer for sure.
jsjoeio commentedon Jul 22, 2022
Woohoo! I just subscribed to that issue.
benz0li commentedon Jul 27, 2022
Neither code-server nor VS Code do install incompatible extension versions.
It is a printing issue in the CLI, though: microsoft/vscode#153201 (comment)
benz0li commentedon Jul 27, 2022
I have just rebuilt an image containing code-server v4.5.1:
installs the latest compatible [release] versions:
I can not reproduce #5031 (comment) with code-server v4.5.1.