[Bug]: Code-Server Version is still 4.4.0 after upgrading to 4.5.0 #5316

Activity

1. balajib-b

   added

   bugSomething isn't workingSomething isn't working

   triageThis issue needs to be triaged by a maintainerThis issue needs to be triaged by a maintainer

   on Jul 2, 2022
2. thediveo commented on Jul 3, 2022

   

   thediveo

   on Jul 3, 2022

   More actions

   Confirming for arm64 .deb on Ubuntu 21.04 arm64: systemctl status code-server shows v4.5.0 in the logs, but even after clearing browser caches the web UI always shows v4.4.0 and the wrong commit hash.
3. AalmanSadath commented on Jul 3, 2022

   

   AalmanSadath

   on Jul 3, 2022

   More actions

   Confirmed on Debian for arm64 and amd64 with individual .deb packages as well as using install script.
4. GuillaumeLazar commented on Jul 6, 2022

   

   GuillaumeLazar

   on Jul 6, 2022

   Last edited by GuillaumeLazar

   More actions

   Same issue after upgrading from v4.4.0 to v4.5.0 using the install.sh script on Ubuntu 22.04 LTS (amd64).

   $ dpkg -s code-server | grep Version
   Version: 4.5.0

   code-server "About popup" displays:

   code-server: v4.4.0
   Code: 1.68.1
   Commit: 30d9c6cd9483b2cc586687151bcbcd635f373630
5. LCMilstein commented on Jul 6, 2022

   

   LCMilstein

   on Jul 6, 2022

   More actions

   Same issue trying multiple install approaches, including the GUI in Docker on Synology
6. benz0li commented on Jul 8, 2022

   

   benz0li

   on Jul 8, 2022

   Contributor

   More actions

   @jsjoeio Also reproducible at https://vscode-r.jupyter.b-data.ch with image R (base:test) + code-server as your account is still whitelisted.

   JupyterLab > Terminal:

   $ code-server --version
   4.5.0 02b9d7ee856e31d9008d1ff24a175ff03b49010e with Code 1.68.1

   code-server > Help > About:

   
7. benz0li commented on Jul 8, 2022

   

   benz0li

   on Jul 8, 2022

   Contributor

   More actions

   Cross reference: #5326
8. somnisomni commented on Jul 16, 2022

   

   somnisomni

   on Jul 16, 2022

   Last edited by somnisomni

   More actions

   In released code-server-4.5.0-linux-amd64.tar.gz/lib/vscode/product.json, seems like some have-to-be-changed properties remain as same as v4.4.0 one.

   
9. jsjoeio commented on Jul 18, 2022

   

   jsjoeio

   on Jul 18, 2022

   Contributor

   More actions

   I see this as well. I think there was a "race condition" that happened with the 4.5.0 release. We normally create a branch called v4.5.0 for the release then tag it the same but GH added something that doesn't allow them to be the same anymore.

   #5352 should

   I'm testing right now before releasing 4.5.1 and still see this issue so we may need to fix this before releasing:

   
10. jsjoeio

    added

    high-priorityThis issue needs to be resolved ASAPThis issue needs to be resolved ASAP

    and removed

    triageThis issue needs to be triaged by a maintainerThis issue needs to be triaged by a maintainer

    on Jul 18, 2022
11. jsjoeio

    added this to the 4.5.1 milestone on Jul 18, 2022
12. jsjoeio

    self-assigned this

    on Jul 18, 2022
13. jsjoeio

    added a commit that references this issue on Jul 19, 2022

    fix(ci): add package.json.version to code cachekey

    ...

    This issue will close once commit 3cd3475 is merged into the 'main' branch.

    3cd3475
14. jsjoeio commented on Jul 19, 2022

    

    jsjoeio

    on Jul 19, 2022

    Last edited by jsjoeio

    Contributor

    More actions

    We think this is because CI hit the cache when releasing 4.5.0 so it didn't rebuild leading to this issue.

    I will test, verify and then close if it fixes it.

    See 3cd3475
15. jsjoeio commented on Jul 19, 2022

    

    jsjoeio

    on Jul 19, 2022

    Contributor

    More actions

    fixed via 3cd3475

    

    This will be updated in the next release.

    👍React with 👍2Reacted by Guillaume Lazar and somni
16. jsjoeio

    closed this as completedon Jul 19, 2022
17. jsjoeio

    added a commit that references this issue on Jul 19, 2022

    release: 4.5.1 (#5354)

    ...

    This issue will close once commit f4fc2eb is merged into the 'main' branch.

    f4fc2eb