Repository navigation
[Bug]: Unable to run project on macOS 13 #5770
Description
Is there an existing issue for this?
- I have searched the existing issues
Issue Details
I am following the contributing guide
It's working on Linux without any issues. but on mac, there is an issue with applying the patches.
when I run quilt push -a there are errors.
Am I missing something?
Steps to Reproduce
- Follow the contribution guide on Mac M1
Expected
The patches should be applied
Actual
There are errors and I get a forbidden message when I run code-server on the browser.
According to the docs, this happens when the patches are not applied correctly
Logs
Applying patch patches/proposed-api.diff
patching file 'lib/vscode/src/vs/workbench/services/extensions/common/abstractExtensionService.ts'
Can't backup '/var/folders/f1/bwc053990rg36bl7bc6bv6940000gn/T/patchoQQ2sGvMSLk', output is in '/var/folders/f1/bwc053990rg36bl7bc6bv6940000gn/T/patchoQQ2sGvMSLk': No such file or directory
patching file 'lib/vscode/src/vs/workbench/services/extensions/common/extensions.ts'
Can't backup '/var/folders/f1/bwc053990rg36bl7bc6bv6940000gn/T/patchoQQ2sGvMSLk', output is in '/var/folders/f1/bwc053990rg36bl7bc6bv6940000gn/T/patchoQQ2sGvMSLk': No such file or directory
Patch patches/proposed-api.diff appears to be empty; applied
Applying patch patches/marketplace.diff
patching file 'lib/vscode/src/vs/platform/product/common/product.ts'
Can't backup '/var/folders/f1/bwc053990rg36bl7bc6bv6940000gn/T/patchoIe3etLqZrR', output is in '/var/folders/f1/bwc053990rg36bl7bc6bv6940000gn/T/patchoIe3etLqZrR': No such file or directory
patching file 'lib/vscode/src/vs/server/node/webClientServer.ts'
Can't backup '/var/folders/f1/bwc053990rg36bl7bc6bv6940000gn/T/patchoIe3etLqZrR', output is in '/var/folders/f1/bwc053990rg36bl7bc6bv6940000gn/T/patchoIe3etLqZrR': No such file or directory
patching file 'lib/vscode/src/vs/platform/extensionResourceLoader/common/extensionResourceLoader.ts'
Can't backup '/var/folders/f1/bwc053990rg36bl7bc6bv6940000gn/T/patchoIe3etLqZrR', output is in '/var/folders/f1/bwc053990rg36bl7bc6bv6940000gn/T/patchoIe3etLqZrR': No such file or directory
1 out of 2 hunks failed--saving rejects to 'lib/vscode/src/vs/platform/extensionResourceLoader/common/extensionResourceLoader.ts.rej'
Patch patches/marketplace.diff does not apply (enforce with -f)
Activity
jsjoeio commentedon Nov 10, 2022
Hmm 🤔 Looking into this right now. I'm on macOS (Intel).
jsjoeio commentedon Nov 10, 2022
This is strange. I'm seeing similar behavior. Maybe #5751 didn't get applied correctly. I will update the patches now.
rahulshinde11 commentedon Nov 10, 2022
I tried in the
release/v4.8.2branchLooks like it has the same issue, can the quilt tool be incompatible? I'm on macOs Ventura
jsjoeio commentedon Nov 10, 2022
False alarm. I did a fresh clone and it all works. Can you please try on
main? I believemainandrelease/v4.8.2point to different submodule commits so you'll need to make sure you rungit submodule update --initafter switching branchesrahulshinde11 commentedon Nov 10, 2022
I did a fresh clone, same issue.
rahulshinde11 commentedon Nov 10, 2022
I had it checked in another macOs Ventura with M1. Same issue.
jsjoeio commentedon Nov 10, 2022
Hmm...I wonder if this is only an issue on M1 then.
jsjoeio commentedon Nov 10, 2022
I couldn't find any related bugs here: http://savannah.nongnu.org/bugs/?group=quilt
rahulshinde11 commentedon Nov 10, 2022
M1 users using
quiltmight be lessChandanWarad commentedon Nov 10, 2022
Facing same issue on M1 macOS version 13.[-][Bug]: Unable to run project on Mac[/-][+][Bug]: Unable to run project on Mac with M1[/+]jsjoeio commentedon Nov 10, 2022
What version of
quiltare you running? I'm running0.67rahulshinde11 commentedon Nov 10, 2022
same, installed using
brew install quiltjsjoeio commentedon Nov 10, 2022
Hmm..what shell are you using? I'm not sure what that backup error is. Do you want to raise an issue in quilt? That might be the best next step
rahulshinde11 commentedon Nov 12, 2022
I use
zsh, do I need to register on the link you sent and raise an issue? I can't find the project on githubrobertmathews commentedon Nov 14, 2022
I stumbled across this bug while searching for the same error in one of my own projects that uses quilt. The bug appears to be in the macOS 13
patchprogram -- it fails with this error if both--backupand--prefixare used and the target to be patched has multiple levels (which often happens withquilt). It happens on my Intel-based Mac, not just an M1 Mac.Here's a reproducible demonstration of the problem. This works, as you would expect:
However, if you introduce different levels into the patch file, like this:
... then you get the error:
This presumably happens because in the first example, it tries to create the backup file at
patchtemp/tempdir/temp1, and that works fine sincepatchtemp/tempdiralready exists. But in the second case, it tries to create it atpatchtemp/tempdir/patchtemp/temp1, which requires thatpatchmake a temporary directory atpatchtemp/tempdir/patchtempfirst. But it's instead creating it at/var/folders/nb/2gx6t6wx63b30222g0r47w6c0000gn/T/patchoSGifYqRkQK.This problem is new with macOS 13, so I reported it earlier today to Apple using the Feedback Assistant. I also reported it to https://savannah.nongnu.org/bugs/?group=quilt.
robertmathews commentedon Nov 15, 2022
FYI, you can work around this problem by installing GNU patch on a Mac using homebrew:
Be sure to close your existing console window and open a new one after installing it to test this (otherwise it may still use the original Apple "patch").
[-][Bug]: Unable to run project on Mac with M1[/-][+][Bug]: Unable to run project on macOS 13[/+]rahulshinde11 commentedon Nov 17, 2022
Another workaround would be to run the command inside a docker container.
jsjoeio commentedon Nov 30, 2022
EDIT: Looks like @robertmathews did, thank you!