Skip to content

Migrate to Node 18 #6230

Closed
Closed

Description

@henkery

What is your suggestion?

Migrate code-server to use nodejs 18 instead of 16

Why do you want this feature?

nodejs 16 reaches EOL on september 2023 https://nodejs.org/en/blog/announcements/nodejs16-eol

Are there any workarounds to get this functionality today?

Are you interested in submitting a PR for this?

I might look into making this work in a few months from now

Activity

  1. code-asher commented on May 30, 2023

    @code-asher
    Member

    We can do this once VS Code updates to Node 18.

  2. added
    blockedThis issue cannot proceed due to external factors
    on May 30, 2023
  3. henkery commented on Jun 1, 2023

    @henkery
    Author
  4. changed the title [-][Feat]: migrate to nodejs 18 as nodejs 16 reaches EOL very soon[/-] [+]Migrate to Node 18[/+] on Jun 26, 2023
  5. skapin commented on Jul 20, 2023

    @skapin

    do you have any information on when it would be available ? september is near.

  6. henkery commented on Jul 20, 2023

    @henkery
    Author

    We are waiting on vscode to migrate first
    seems they moved the work to a new ticket here microsoft/vscode#188268
    ofc code-server (or vscode for that matter) won't just instantly break but it will be considered a security risk

  7. skapin commented on Jul 20, 2023

    @skapin

    Yes, but looks like it will not be available for several month. Internally they are afraid of moving to electron 25....

    meanwhile, node 16 and openssl1.1.1 is ending in september ><

    Thank you, I'm crossing my finger.

    For information, i'm bumping all my jupyterlab stack to 4.0 and node 18 is asked (but looks like not mandatory) anyway, I have the same issue with openssl 1.1.1 VS 3 ><

  8. benz0li commented on Jul 20, 2023

    @benz0li
    Contributor

    For information, i'm bumping all my jupyterlab stack to 4.0

    @skapin I stay with v3.6.x for my JupyterLab docker stacks because of jupyterlab/jupyterlab#14590.

  9. skapin commented on Jul 20, 2023

    @skapin

    @benz0li yeah, but my release plan is for sept/october, and I want to do it early, at least maximize compatibility.
    thank you for the link, I will keep it !!!

    It's out for several months now. I will clean old extension and co. Cleaning time :p

  10. benz0li commented on Aug 7, 2023

    @benz0li
    Contributor

    ℹ️ Update to Electron 25 (Issue: microsoft/vscode#184021; Pull Request: microsoft/vscode#188268) is part of the Iteration Plan for August 2023 [DRAFT].

  11. removed
    blockedThis issue cannot proceed due to external factors
    on Sep 20, 2023
  12. jonathanflackUSAF commented on Oct 21, 2023

    @jonathanflackUSAF

    One particularly important reason for pressing Microsoft's VSCode team on this is this specific change is required to eliminate a number of Critical and High scoring CVE's, and there is a risk in many high compliance environments that these codebases could be delisted from authorized lists if this doesn't happen quickly.

    We are seeing this happen in real time with a certain Australian company who make Agile process management software. Missions in the federal government are being told to immediately isolate and cut off all access to these systems.

    This is a pretty dark stain on any closed source or OSS solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementSome improvement that isn't a feature

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions