[Feat]: I wonder if you can create a choice that we can chose config file in other path #6240

Activity

1. Eggwardhan

   added

   enhancementSome improvement that isn't a featureSome improvement that isn't a feature

   on May 29, 2023
2. Eggwardhan

   changed the title [-][Feat]: I wonder if you can create [/-] [+][Feat]: I wonder if you can create a choice that we can chose config file in other place[/+] on May 29, 2023
3. Eggwardhan

   changed the title [-][Feat]: I wonder if you can create a choice that we can chose config file in other place[/-] [+][Feat]: I wonder if you can create a choice that we can chose config file in other path[/+] on May 29, 2023
4. code-asher commented on May 30, 2023

   

   code-asher

   on May 30, 2023

   Member

   More actions

   You can change the config file with --config, is that what you mean?

   For example:

   code-server --config=/tmp/config.yaml
   

   The data directory can also be changed:

   code-server --user-data-dir /tmp/code-server-data
   
5. mirekphd commented on Jun 26, 2023

   

   mirekphd

   on Jun 26, 2023

   More actions

   --config

   Yes, so say your docs (at least for --user-data-dir), but neither of these two options seems to be available in code-server binary:

   (base) coder@5800d4264eeb:/home/jovyan$ code-server --version
   1.79.2
   695af097c7bd098fbf017ce3ac85e09bbc5dda06
   x64
   
   (base) coder@5800d4264eeb:/home/jovyan$ code-server --user-data-dir
   Ignoring option 'user-data-dir': not supported for code-server.
   
   (base) coder@5800d4264eeb:/home/jovyan$ code-server --config
   Ignoring option 'config': not supported for code-server.
   
6. mirekphd commented on Jun 26, 2023

   

   mirekphd

   on Jun 26, 2023

   Last edited by mirekphd

   More actions

   neither of these two options seems to be available in code-server binary:

   Turns out there are two instances of code-server available at runtime, and the one which is executed by default (without specifying its path) is the "wrong one" (/usr/lib/../remote-cli/code-server).
   The "right one" does have both --user-data-dir and --config options available.

   More info:

   # have been using the wrong one:
   (base) coder@5800d4264eeb:/home/jovyan$ which code-server
   /usr/lib/code-server/lib/vscode/bin/remote-cli/code-server
   
   (base) coder@5800d4264eeb:/home/jovyan$ /usr/lib/code-server/lib/vscode/bin/remote-cli/code-server --config
   Ignoring option 'config': not supported for code-server.
   
   (base) coder@5800d4264eeb:/home/jovyan$ /usr/lib/code-server/lib/vscode/bin/remote-cli/code-server --user-data-dir
   Ignoring option 'user-data-dir': not supported for code-server.
   
   #
   #
   # ... but finally realized there is another code-server in the container (still a mystery to me why),
   # so I switched to the "right one" (the one I actually directly installed in the Dockerfile):
   (base) coder@5800d4264eeb:/home/jovyan$ /usr/bin/code-server --user-data-dir
   [2023-06-26T11:47:53.539Z] error --user-data-dir requires a value
   
   (base) coder@5800d4264eeb:/home/jovyan$ /usr/bin/code-server --config
   [2023-06-26T11:48:06.579Z] error --config requires a value
   

   Probably aliasing the correct code-server version could prevent such cases (ping to the docs authors).
7. code-asher commented on Jun 26, 2023

   

   code-asher

   on Jun 26, 2023 via email

   Member

   More actions

   Yup this is the expected (but confusing) behavior. VS Code provides their own `code-server` binary when inside the integrated terminal. It is a separate binary meant only to interact with the current session of code-server without the ability to spin up a new one. Personally I would rather see it be the same binary but we try not to deviate from upstream. I can only guess as to their intent but perhaps they consider launching a new server while already inside VS Code to be an invalid use case. Documenting this difference seems like a good idea to me. Maybe a patch to the remote-cli binary to mention that it is a different binary when the options are invalid could also be useful.
8. code-asher commented on Jun 26, 2023

   

   code-asher

   on Jun 26, 2023

   Last edited by code-asher

   Member

   More actions

   Maybe it would be good to override this with our binary though to provide a consistent experience. Before that though we would want to implement the remaining features missing from ours that are present in VS Code's (--wait for example).
9. code-asher commented on Jul 13, 2024

   

   code-asher

   on Jul 13, 2024

   Member

   More actions

   I think we ended up leaving the other binary so as to have parity with Codespaces.
10. code-asher

    closed this as not plannedon Jul 13, 2024