Skip to content

Three uncovered pre-existing spots on the monitoring and dashboard surface #337

Open

Description

@codingjoe

Three pre-existing lines on the dashboard and reputation surfaces have no test.

Work reference: branch codingjoe-weekly-digest, commits 2ace45d to 6f28eac, weekly sending digest. This work is from the superJoe crew. testJoe measured the two apps for that change, and these lines were already dark.

side quest: services/email/dashboard/context_processors.py:8 return {} when no org is selected is uncovered. Pre-existing, not in this diff. [services/email/dashboard/context_processors.py]

side quest: reputation/fbl_report_detail.html lines 43, 51-54, 72-77, 81-88 are uncovered. Pre-existing, not in this diff. [services/email/reputation/templates/reputation/fbl_report_detail.html]

side quest: reputation/fbl_report_list.html line 68 is uncovered. Pre-existing, not in this diff. [services/email/reputation/templates/reputation/fbl_report_list.html]

Measured with uv run --group test pytest services/email/reputation services/email/dashboard --cov=services/email/reputation --cov=services/email/dashboard --cov-report=term-missing: 216 passed, 87 percent. Template line counts read 0 percent for every template in that run, including ones that a rendering test provably renders. The fbl template lines therefore want a rendering assertion, not a coverage number. The context processor line is the anonymous, no-org path.

Related: #329, #299, #292, #296, #297.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    side questOut-of-scope finding, deferred to its own issuetestCoverage, ghost and delulu branches

    Projects

    • Status
      Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions