Child entities does not permit additional rendering to be called like the root parent entities

[c-falardeau]

Hello, great lib by the way!
I'm currently evaluating its usage for a project.

I'm wondering if it was intentional that the function you pass as the children for < BuilderEntities > is not get called when processing child entities (entities of entities).

I would need the possibilities to render additional content like the parent entities do.

So it is intentional or an issue that I can create or maybe I could contribute ?

Best regards,
Chris

[sandulat]

Hey @c-falardeau! Thanks so much for reporting this. You're right, this isn't the expected behavior. The regression was introduced in the v0.2.0 release. Please upgrade to 0.2.3 and let me know if the issue is resolved.

[c-falardeau]

Hello @sandulat, thanks for your quick answer and action! I'll give it a try :)

Best regards,
Chris

[SnapeEye]

Maybe I miss something, but I cannot something new.
So I'm curios what is the actual way to use this fix. As far as I thought, if entity is having children - each child should be accessible while rendering (like children mapping).
Is it possible to point the exact place where this update can be seen (like inside render? where exactly, maybe there are some conditions?)? And maybe somebody could describe a use case for this. I'm a bit confused here...

For example I got this schema (section is just a grouping element, like block):

{
   entities: {
       'uuid-1': {
           type: 'section',
           children: ['uuid-2', 'uuid-3'],
           attributes: {},
       },
       'uuid-2': {
           type: 'paragraph',
           attributes: {
              content: 'text 1',
           },
           parentId: 'uuid-1',
       },
       'uuid-3': {
           type: 'paragraph',
           attributes: {
              content: 'text 2',
           },
           parentId: 'uuid-1',
       },
    },
   root: ['uuid-1'],
}

[sandulat]

@SnapeEye The BuilderEntities and BuilderEntity components accept a function as their children prop.

<BuilderEntities builderStore={builderStore} components={{}}>
  {(props) => (
    <div style={{ border: "1px solid red" }}>
      {/* This represents each rendered arbitrary entity. */}
      {props.children}
    </div>
  )}
</BuilderEntities>

This is typically used to wrap each rendered entity with additional UI. For example, to render a "Delete" button next to each entity or anything else.

The bug was that this function was previously called only for top-level (root) entities, not for their descendants. With the released fix, the wrapper will now be applied to all entities — including deeply nested ones across any number of levels (children, grandchildren, and beyond).

Let me know what you're trying to achieve.

[SnapeEye]

@SnapeEye The BuilderEntities and BuilderEntity components accept a function as their children prop.

<BuilderEntities builderStore={builderStore} components={{}}>
  {(props) => (
    <div style={{ border: "1px solid red" }}>
      {/* This represents each rendered arbitrary entity. */}
      {props.children}
    </div>
  )}
</BuilderEntities>

This is typically used to wrap each rendered entity with additional UI. For example, to render a "Delete" button next to each entity or anything else.

The bug was that this function was previously called only for top-level (root) entities, not for their descendants. With the released fix, the wrapper will now be applied to all entities — including deeply nested ones across any number of levels (children, grandchildren, and beyond).

Let me know what you're trying to achieve.

Yeah, I get it now. Also I went through the 0.2.3. code and it seems to be pretty clear of what happened.
Small but valuable update tbh.

[c-falardeau]

Hello @sandulat, sorry for the delay! The fix works thanks!