aft_callgraph includeTests:false still lists Rust callers in an inline #[cfg(test)] module #973

Summary

With includeTests: false, aft_callgraph still lists callers that are Rust unit tests in an inline #[cfg(test)] mod tests { … }. The filter checks only the file path. Rust unit tests are usually in the same file as the code, so for a Rust crate includeTests: false does not hide most tests. The parameter description says "Defaults to false; tests are hidden."

Reproduction

Checked on main at 8876c44, with the binary built from that commit and isolated storage.

Cargo.toml with [package] name = "fx", and src/lib.rs:

pub fn production() -> u32 {
    1
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn checks_production() {
        assert_eq!(production(), 1);
    }
}

NDJSON requests after configure:

{"command":"callers","file":"<root>/src/lib.rs","symbol":"production","depth":3,"includeTests":false}
{"command":"callers","file":"<root>/src/lib.rs","symbol":"production","depth":3,"includeTests":true}

Both responses are the same:

"callers": [{"file": "src/lib.rs", "callers": [{"symbol": "tests::checks_production", "line": 11}]}], "total_callers": 1

With includeTests: false, the expected result is no callers, or a note that test callers in production files are not filtered.

Cause

crates/aft/src/commands/callgraph_store_adapter.rs filters with is_test_file(path) only (:117, :438, :442, :522, :574). is_test_file (crates/aft/src/inspect/job.rs:936) classifies the file name and directory, not the item. A #[cfg(test)] module or a #[test] function in a production file is not detected.

Question

Which behaviour is intended?

1. includeTests applies to items too. It hides callers in a #[cfg(test)] module or with a #[test] attribute. Other languages with inline tests can get the same rule.
2. includeTests applies only to test files: change the description from "tests are hidden" to "test files are hidden", and tell the agent that inline test callers stay in the result.

Option 1 matches what an agent expects from the current description.