Repository navigation
bug: vertical sharding aggregation with absent displays shard by label #5204
Description
Describe the bug
query_fuzz_test.go:169: case 0 results mismatch.
instant query: count_values without (job) ("value", absent({series="7"}))
res1: {series="7", value="1"} => 1 @[1678393035.187]
res2: {__CORTEX_SHARD_BY__="CAEQAiIDam9i", series="7", value="1"} => 1 @[1678393035.187]
{__CORTEX_SHARD_BY__="EAIiA2pvYg==", series="7", value="1"} => 1 @[1678393035.187]
Got this bug when running the PromQLsmith test.
Ran a query count_values without (job) ("value", absent({series="7"})). Here {series="7"} couldn't match anything so absent() is expected to return a series.
res1 is from non vertical sharding Cortex and it gives expected result. res2 runs vertical sharding Cortex and it gave me bad results and additional __CORTEX_SHARD_BY__ label.
Activity
[-]bug: vertical sharding count_values gets hidden labels[/-][+]bug: vertical sharding with count_values[/+][-]bug: vertical sharding with count_values[/-][+]bug: vertical sharding aggregation with `absent` displays shard by label[/+]yeya24 commentedon Mar 9, 2023
Seems the
count_valuesaggregation doesn't matter here.Got another case with
maxandabsentthat displays the additional shard label.yeya24 commentedon Mar 9, 2023
Probably we should just disable
absentandabsent_over_timefor vertical sharding and then this can be resolved.yeya24 commentedon Mar 9, 2023
Should be solved by thanos-io/thanos#6201
fix(integration): skip `or vector(...)` in fuzz query generator
fix(integration): skip `or vector(...)` in fuzz query generator
fix(integration): skip `or vector(...)` in fuzz query generator (#7551)