Skip to content

retrieveFile interprets empty string as "no response" #33

Open
Open
retrieveFile interprets empty string as "no response"#33

Description

@cspotcode
cspotcode
opened on Oct 16, 2021

node-source-map-support/source-map-support.js

Line 147 in 817f84b

var retrieveFile = handlerExec(sharedData.retrieveFileHandlers, sharedData.internalRetrieveFileHandlers);

node-source-map-support/source-map-support.js

Lines 129 to 135 in 817f84b

function handlerExec(list, internalList) {
return function(arg) {
for (var i = 0; i < list.length; i++) {
var ret = list[i](arg);
if (ret) {
return ret;
}

If a file is empty, retrieveFile can return empty string. This is falsey, and today is erroneously interpreted as "no response," causing subsequent retrieveFile handlers to be invoked.

We can change retrieveFile to allow returning undefined and fix the logic to interpret empty string as empty file.

Note: Is a breaking change.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions