Validate SSL certificate for electrum servers #523

Activity

1. sneurlax commented on May 23, 2023

   

   sneurlax

   on May 23, 2023

   Member

   More actions

   https://github.com/cypherstack/stack_wallet/blob/b41d31fd32738879f7fe52dc769faa82c60f377b/lib/electrumx_rpc/rpc.dart#LL58C26-L58C26 is where certs are currently ignored
2. sneurlax commented on May 25, 2023

   

   sneurlax

   on May 25, 2023

   Member

   More actions

   Without adding too much additional UI, we could add an advanced setting to accept bad certificates. It'd be better to add it with a more intuitive design, but that could be a minimalist change which could add some safety while still preserving the ability to connect to servers with bad or self-signed certificates
3. sneurlax commented on May 25, 2023

   

   sneurlax

   on May 25, 2023

   Last edited by sneurlax

   Member

   More actions

   Without adding too much additional UI, we could add an advanced setting to accept bad certificates. It'd be better to add it with a more intuitive design, but that could be a minimalist change which could add some safety while still preserving the ability to connect to servers with bad or self-signed certificates

   nvm, having discussed this, it'd probably be better to do what we do for monero or else show a dialog/modal
4. danrmiller commented on Jun 21, 2023

   

   danrmiller

   on Jun 21, 2023

   CollaboratorAuthor

   More actions

   Oops, I somehow forgot there was already #245. I'll close that one since unlike this one it has no discussion.
5. sneurlax

   self-assigned this

   on Jul 10, 2024