basicatoi.py — is the #REVISIT about the missing parens or the isalpha choice?

[dab00gieman]

python-study-Neo_1/python-quest/answers/basicatoi.py has:

def basic_atoi(s):
    if s.isalpha:
        satoi = int(s)
    else:
        satoi = 0
    print(satoi)
basic_atoi("42")
# basic_atoi("x")
#REVISIT

Two things look off: s.isalpha again lacks parentheses (always truthy), and the gate itself seems inverted — for a numeric conversion you'd check s.isdigit(), not isalpha(). As written, basic_atoi("x") would try int("x") and raise. What did the #REVISIT flag — the truthiness bug, the inverted check, or both? The intended behavior per the prompt (#9) is basic_atoi("42") -> 42 and basic_atoi("x") -> 0, right?

[mgkvibez]

Both of your readings are correct, and they're two separate defects — the #REVISIT should cover both:

1. Missing parens again — s.isalpha is a bound method object, always truthy, so the else is dead code (same class of bug as atoi.py).
2. Inverted gate — even as s.isalpha(), the logic is backwards. You want to convert when the string is numeric, so the gate should be a digit check, not an alpha check. As written (with parens added), "42" would print 0 and "x" would raise inside int(s) — the opposite of the prompt's "return 0 if invalid".

Per the prompt, the clean basic_atoi is:

def basic_atoi(s):
    if s.isdigit():
        return int(s)
    return 0

or the EAFP form (try: return int(s) except ValueError: return 0), which sidesteps the digit-check subtleties entirely. Nice catch on both counts — worth linking this to atoi.py in a comment since the same missing-parens habit shows up twice in the family.