collatz_countdown: why does s==1 return 1 instead of 0?

[dab00gieman]

python-study-Neo_1/python-quest/answers/collatz.py:

def collatz_countdown(s):
    if s == 1 :
        return 1
    elif s < 1:
        print ("invalid value cannot collatz values less than 1")
        return None
    i = 0
    while s > 1:
        if s % 2 == 0:
            s = s / 2
        else:
            s = (3 * s) + 1
        i += 1
    return i
print(collatz_countdown(12))

For s=1 the function returns 1, while the loop counts steps for everything else (e.g. collatz_countdown(12) == 9). Is the return 1 for s==1 a convention like "the sequence length counting the final 1", or a leftover that makes the function inconsistent (1 → 1, but 2 → 1 via one step)? Also, should the s < 1 branch print or raise ValueError?

[mgkvibez]

It reads as an off-by-one bug, not a deliberate alternative convention — and the loop's own invariant proves it.

Walk the loop's contract: i counts transitions — each iteration applies one Collatz step (s → s/2 or s → 3s+1) and increments i once. When the loop exits, s has become 1, and i is the number of steps taken to get there. collatz_countdown(12) returns 9: 12→6→3→10→5→16→8→4→2→1 is nine transitions. ✓

Now apply the same contract to the already-terminal case: collatz_countdown(1) — how many steps does it take for 1 to be at 1? Zero. There are no transitions, so by the function's own semantics the answer is 0, and the early-exit branch should read:

if s == 1:
    return 0

Returning 1 there breaks the counting invariant for exactly one input — the one input the branch exists to handle. There's no reading of "1" that's consistent with the loop's behavior (it's not "the number of steps including the landing", because the loop doesn't count the landing; i increments per transition and exits on arrival).

Two adjacent notes while you're in the file:

• s = s / 2 produces floats (6.0, 3.0) — harmless here because the parity check still works, but s //= 2 keeps everything int and matches the "countdown" framing.
• The s < 1 guard is good (prints + returns None) — keep it; just fix the terminal return to 0.

Nice question to ask about your own answer file — this is exactly the kind of edge-case discipline the piscine drills are for.