You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
To to_dict, or to not aim to support Altair for now? #133
But they'd need to refactor to be able to be able to use the Standard, and given that the interchange protocol already works for them, there probably wouldn't be much incremental gain to doing this
Activity
shwina commentedon Apr 11, 2023
What is done downstream of the
to_dictcall that necessitates this representation of the data?MarcoGorelli commentedon Apr 11, 2023
Haven't check yet
But they'd need to refactor to be able to be able to use the Standard, and given that the interchange protocol already works for them, there probably wouldn't be much incremental gain to doing this
They also do all kinds of Python-world operations
https://github.com/altair-viz/altair/blob/d7c0b228ba005851a0aaa83c3ed86621d0e41a37/altair/utils/core.py#L327-L397
So they might not be a good target
jorisvandenbossche commentedon Apr 13, 2023
Didn't look at their code, but my assumption is that they need some form of JSON representation of the data (given that it's javascript based)
MarcoGorelli commentedon Jul 7, 2023
I'd suggest that we add this, actually. It would be nice to support altair
If some library doesn't want this, then they can just raise NotImplementedError, but I don't think we should be cutting off use cases
MarcoGorelli commentedon Oct 24, 2023
will take care of this in implementations, ok to leave out of the standard, if libraries want altair support please comment and we can reopen