You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jul 25, 2022. It is now read-only.
Repository navigation
This repository was archived by the owner on Jul 25, 2022. It is now read-only.
Right now it returns List[pa.RecordBatch], but it might be more natural to return a pa.Table. For one thing, they have a better repr provided by PyArrow.
Asides from repr, do you see any other advantages?
Mostly was just surprised coming from PyArrow, but it sounds like Rust usually just represents results as a sequence of record batches.
Perhaps it would be better to add a new method to return a pa.Table instead.
Yeah perhaps that's a better path. A to_table() method is common in PyArrow. If we eventually get the C Streaming data interface implemented in arrow-rs, we could also provide a to_reader().
Activity
matthewmturner commentedon Feb 20, 2022
Asides from repr, do you see any other advantages?
houqp commentedon Feb 20, 2022
This is to keep the signature in sync with what we have in the Rust core. Perhaps it would be better to add a new method to return a
pa.Tableinstead.wjones127 commentedon Feb 20, 2022
Mostly was just surprised coming from PyArrow, but it sounds like Rust usually just represents results as a sequence of record batches.
Yeah perhaps that's a better path. A
to_table()method is common in PyArrow. If we eventually get the C Streaming data interface implemented in arrow-rs, we could also provide ato_reader().