IMPR: Modernize pre-commit #1271

Activity

1. d-v-b

   added

   enhancementIndicates new improvementsIndicates new improvements

   triageIndicates issues, pull requests, or discussions need to be reviewed for the first timeIndicates issues, pull requests, or discussions need to be reviewed for the first time

   on Sep 16, 2025
2. dimitri-yatsenko

   removed

   triageIndicates issues, pull requests, or discussions need to be reviewed for the first timeIndicates issues, pull requests, or discussions need to be reviewed for the first time

   on Oct 16, 2025
3. dimitri-yatsenko

   added this to the DataJoint 2.0 milestone on Oct 16, 2025
4. github-actions commented on Dec 1, 2025

   

   github-actionsBot

   on Dec 1, 2025 – with GitHub Actions

   More actions

   This issue is stale because it has been open for 45 days with no activity.
5. github-actions

   added

   staleIndicates issues, pull requests, or discussions are inactiveIndicates issues, pull requests, or discussions are inactive

   on Dec 1, 2025
6. dimitri-yatsenko

   removed

   staleIndicates issues, pull requests, or discussions are inactiveIndicates issues, pull requests, or discussions are inactive

   on Dec 20, 2025
7. dimitri-yatsenko

   added a commit that references this issue on Jan 8, 2026

   chore: update pre-commit comment to reference ruff

   ...

   This issue will close once commit a6bc04b is merged into the 'master' branch.

   a6bc04b
8. dimitri-yatsenko commented on Jan 8, 2026

   

   dimitri-yatsenko

   on Jan 8, 2026

   Member

   More actions

   This has been implemented. The pre-commit configuration is now modernized:

   Changes Made

   Ruff instead of flake8 and black

   - repo: https://github.com/astral-sh/ruff-pre-commit
     rev: v0.8.4
     hooks:
       - id: ruff
         args: [--fix]  # Auto-fix safe issues
         files: ^(src/|tests/)
       - id: ruff-format
         files: ^(src/|tests/)

   Configuration in pyproject.toml

   All tool configuration is now in pyproject.toml:

   [tool.ruff]
   line-length = 127
   target-version = "py310"
   
   [tool.ruff.lint]
   select = ["E", "W", "F", "C90"]
   ignore = ["E203", "E722"]
   
   [tool.ruff.format]
   quote-style = "double"
   indent-style = "space"
   
   [tool.codespell]
   skip = ".git,*.pdf,*.svg,*.csv,*.ipynb,*.drawio"
   ignore-words-list = "rever,numer,astroid"

   Removed

   • No .codespellrc file (config in pyproject.toml)
   • No .flake8 file (replaced by ruff)
   • No black (replaced by ruff-format)

   Additional hooks added

   • mypy for type checking
   • unit tests run on pre-commit
   • actionlint for GitHub Actions validation
9. dimitri-yatsenko

   closed this as completedon Jan 8, 2026