Added possibility to inject packages into the ansible pipx package - #106
Merged
koralowiec merged 3 commits intoFeb 27, 2025
Merged
Conversation
koralowiec
self-requested a review
February 26, 2025 18:07
koralowiec
added
the
existing feature
koralowiec
requested changes
Feb 27, 2025
koralowiec
left a comment
koralowiec
left a comment
Member
There was a problem hiding this comment.
Hey, thanks for the PR
I have to 2 change requests:
- Left as a code comment:
ansibleshould be always injected - As you introduce a new option for the feature, there should be a new test scenario that confirm it works properly. For example, the test scenario sets
injectionsoption tohcloud requests, and there are checks that confirm that these packages were additionally installed in the environment. If you need help with adding this, let me know, I'm happy to help you
Contributor
Author
|
I added the test case which just looks into the pipx environment and greps the injections |
Member
|
The new version is available to use: https://github.com/devcontainers-extra/features/pkgs/container/features%2Fansible/364134081?tag=2.1.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some ansible addon packages like the Hetzner inventory plugins needs to be installed into the ansible venv.
Currently the ansible package doesn't support installing ansible plugins.
I am also including dependencies now.