Claude - #116
Closed
bertlebee wants to merge 4 commits into
Closed
Conversation
Closed
koralowiec
self-requested a review
April 22, 2025 08:57
koralowiec
added
the
new feature
koralowiec
requested changes
Apr 22, 2025
koralowiec
left a comment
koralowiec
left a comment
Member
There was a problem hiding this comment.
Hi, thanks for the PR!
I have a single comment - Typically, we use npm-package feature to install npm packages globally (if there's node already installed, the feature uses it; otherwise it installs node on its own).
I suggested the changes
Comment on lines
+14
to
+19
| # Install Claude Code globally via npm | ||
| if [ "${VERSION}" = "latest" ]; then | ||
| npm install -g "@anthropic-ai/claude-code" | ||
| else | ||
| npm install -g "@anthropic-ai/claude-code@${VERSION}" | ||
| fi |
Member
There was a problem hiding this comment.
Suggested change
| # Install Claude Code globally via npm | |
| if [ "${VERSION}" = "latest" ]; then | |
| npm install -g "@anthropic-ai/claude-code" | |
| else | |
| npm install -g "@anthropic-ai/claude-code@${VERSION}" | |
| fi | |
| $nanolayer_location \ | |
| install \ | |
| devcontainer-feature \ | |
| "ghcr.io/devcontainers-extra/features/npm-package:1.0.3" \ | |
| --option package='@anthropic-ai/claude-code' --option version="$VERSION" |
Comment on lines
+4
to
+7
| "features": { | ||
| "ghcr.io/devcontainers/features/node:1": {}, | ||
| "claude-code": {} | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| "features": { | |
| "ghcr.io/devcontainers/features/node:1": {}, | |
| "claude-code": {} | |
| } | |
| "features": { | |
| "claude-code": {} | |
| } |
Comment on lines
+11
to
+16
| "features": { | ||
| "ghcr.io/devcontainers/features/node:1": {}, | ||
| "claude-code": { | ||
| "version": "0.2.70" | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| "features": { | |
| "ghcr.io/devcontainers/features/node:1": {}, | |
| "claude-code": { | |
| "version": "0.2.70" | |
| } | |
| } | |
| "features": { | |
| "claude-code": { | |
| "version": "0.2.70" | |
| } | |
| } |
Member
|
Claude Code feature was added in the meantime -> Closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add support for claude code as a feature