Skip to content

chore: fix devcontainer explainshell #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
koralowiec merged 2 commits into from
Sep 12, 2024
Merged

chore: fix devcontainer explainshell #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14df380
chore(devcontainer): stop and remove explainshell if it's running
koralowiec Sep 12, 2024
e1f135b
chore(devcontainer): bump versions and format
koralowiec Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,21 +3,20 @@
"customizations": {
"vscode": {
"extensions": [
"mads-hartmann.bash-ide-vscode",
"ms-python.python",
"ms-python.vscode-pylance",
"DavidAnson.vscode-markdownlint"
]
"mads-hartmann.bash-ide-vscode",
"ms-python.python",
"ms-python.vscode-pylance",
"DavidAnson.vscode-markdownlint"
]
}
},
"features": {
"ghcr.io/devcontainers/features/python:1.1.0": {},
"ghcr.io/devcontainers/features/node:1.3.0": {},
"ghcr.io/devcontainers/features/github-cli:1.0.10": {},
"ghcr.io/devcontainers/features/docker-in-docker:2.5.0": {},
"ghcr.io/devcontainers/features/common-utils:2.1.2": {},
"ghcr.io/devcontainers/features/python:1.6.4": {},
"ghcr.io/devcontainers/features/node:1.6.0": {},
"ghcr.io/devcontainers/features/github-cli:1.0.13": {},
"ghcr.io/devcontainers/features/docker-in-docker:2.11.0": {},
"ghcr.io/devcontainers/features/common-utils:2.5.1": {},
"ghcr.io/lukewiwa/features/shellcheck:0.2.3": {}

},
"postCreateCommand": "/bin/bash -ex ./.devcontainer/setup.sh > postCreateCommand.log"
}
9 changes: 9 additions & 0 deletions .devcontainer/setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,14 @@ npm install -g @devcontainers/cli

pipx install shfmt-py

# Check if the explainshell container is running
if [ "$(docker ps -q -f name=explainshell)" ]; then
# Stop the running container
docker stop explainshell
# Remove the container
docker rm explainshell
fi

# Run a new explainshell container
# this will add hover annotations in shell script files, assuming mads-hartmann.bash-ide-vscod is installed
docker container run --name explainshell --restart always -p 5000:5000 -d spaceinvaderone/explainshell