Skip to content

[feat] Add webi feature - #78

Merged
koralowiec merged 2 commits into
devcontainers-extra:mainfrom
eternasuno:main
Dec 10, 2024
Merged

[feat] Add webi feature#78
koralowiec merged 2 commits into
devcontainers-extra:mainfrom
eternasuno:main

Conversation

@eternasuno

Copy link
Copy Markdown
Contributor

Apologies for the duplicate PR submission. Upon realizing that the repository was forked from devcontainers-contrib/features, the differences in files became substantial. Therefore, the previous PR was closed to ensure a clean and accurate submission.

This new pull request introduces a fresh devcontainer feature:

  1. Webi Installation:Adds support for installing Webi in the development container.

Thank you for reviewing this submission!

@koralowiec
koralowiec self-requested a review December 7, 2024 09:06
@koralowiec koralowiec added the new feature This PR or issue is about adding a new Dev Container feature label Dec 7, 2024

@koralowiec koralowiec left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for putting this into a new PR. I left some questions/change requests

Comment thread src/webi-packages/install.sh
Comment thread src/webi-packages/utils.sh Outdated
Comment thread test/webi-packages/test_alpine.sh
Comment thread src/webi-packages/utils.sh Outdated
Comment thread src/webi-packages/install.sh Outdated
@koralowiec
koralowiec merged commit bc46a4e into devcontainers-extra:main Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature This PR or issue is about adding a new Dev Container feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants