`NVM_VERSION` hard-coded to `0.38.0` on the node feature

[justinyoo]

Hi, Team.

When I look at the install.sh file, the NVM_VERSION value is hard-coded to 0.38.0

features/src/node/install.sh

Line 21 in 82960fd

export NVM_VERSION="0.38.0"

Do we have a reason to pin that specific version instead of getting the latest one (0.39.1 as of today)?

If there's no harm, can I send a PR to get the latest version of the NVM?

[johnnyreilly]

This feels like a good idea (I have no authority on this BTW 😅)

[joshspicer]

Agreed, thanks for pointing that out. I suspect this was originally pinned for a reason, but I don't recall why (and likely it's fine to pick up the latest). Feel free to send the PR :)

[Chuxel]

There are a few other bugs I ran into so I bumped the nvm version (since 0.38.0 has issues), and added the ability to pick a nvm version into PR #241

[samruddhikhandale]

Closing as fixed with #241