Skip to content

Rust: add the option to install additional targets - #1033

Merged
Samruddhi Khandale (samruddhikhandale) merged 3 commits into
devcontainers:mainfrom
yaleman:yaleman/issue1032
Jul 10, 2024
Merged

Rust: add the option to install additional targets#1033
Samruddhi Khandale (samruddhikhandale) merged 3 commits into
devcontainers:mainfrom
yaleman:yaleman/issue1032

Conversation

@yaleman

Copy link
Copy Markdown
Contributor

Fixes #1032

  • Adds the "targets" input
  • Did some shellcheck-based linting of the shell script
  • Added a test for the new option

@yaleman
James Hodgkinson (yaleman) requested a review from a team as a code owner July 7, 2024 03:12
@yaleman

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time in contributing this PR. The new Feature option addition makes sense to me and will be very helpful.

Left some minor comments.
Also, thanks for optimizing the current script 🙏

Comment thread src/rust/devcontainer-feature.json Outdated
Comment thread src/rust/devcontainer-feature.json Outdated
Comment thread src/rust/install.sh
Co-authored-by: Samruddhi Khandale <samruddhikhandale@github.com>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thank you ✨

@samruddhikhandale
Samruddhi Khandale (samruddhikhandale) merged commit 09d5632 into devcontainers:main Jul 10, 2024
@yaleman
James Hodgkinson (yaleman) deleted the yaleman/issue1032 branch July 10, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rust: add the option to install additional targets

2 participants