Skip to content

[desktop-lite] - vnc_resolution - set thru env var - #1112

Merged
Samruddhi Khandale (samruddhikhandale) merged 7 commits into
devcontainers:mainfrom
gauravsaini04:desktop-lite_vnc-resolution_test_env_var
Sep 9, 2024
Merged

[desktop-lite] - vnc_resolution - set thru env var#1112
Samruddhi Khandale (samruddhikhandale) merged 7 commits into
devcontainers:mainfrom
gauravsaini04:desktop-lite_vnc-resolution_test_env_var

Conversation

@gauravsaini04

@gauravsaini04 Gaurav Saini (gauravsaini04) commented Sep 2, 2024

Copy link
Copy Markdown
Contributor

Feature Name

  • Desktop-lite

Description

  • Escaped the variables in desktop-init.sh file at the init of the file as a solution to feature's issue #945

changelog

  • VNC_RESOLUTION as an env. var. should get picked up by the desktop-init.sh file due to the above mentioned changes

Comment thread src/desktop-lite/install.sh
Comment thread src/desktop-lite/install.sh Outdated
Comment thread src/desktop-lite/install.sh Outdated
Comment thread test/desktop-lite/scenarios.json

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[desktop-lite] Entrypoint script does not use VNC_RESOLUTION defined by containerEnv

2 participants