Skip to content

Fix: Handle case where Python version is already installed (#222) - #1115

Merged
Samruddhi Khandale (samruddhikhandale) merged 5 commits into
devcontainers:mainfrom
gvatsal60:bugfix/python3_exit_1
Oct 8, 2024
Merged

Fix: Handle case where Python version is already installed (#222)#1115
Samruddhi Khandale (samruddhikhandale) merged 5 commits into
devcontainers:mainfrom
gvatsal60:bugfix/python3_exit_1

Conversation

@gvatsal60

@gvatsal60 Vatsal Gupta (gvatsal60) commented Sep 5, 2024

Copy link
Copy Markdown
Contributor

@gvatsal60
Vatsal Gupta (gvatsal60) requested a review from a team as a code owner September 5, 2024 06:24
@gvatsal60

Copy link
Copy Markdown
Contributor Author

Hi Samruddhi Khandale (@samruddhikhandale)
Could you check out the pull request when you have a moment?

@samruddhikhandale

Copy link
Copy Markdown
Member

Vatsal Gupta (@gvatsal60) The code is intentionally in place. Why would you want to remove exit 1? If the version still exists, why not pass none or another version?

@gvatsal60

Copy link
Copy Markdown
Contributor Author

Vatsal Gupta (@gvatsal60) The code is intentionally in place. Why would you want to remove exit 1? If the version still exists, why not pass none or another version?

I am looking into it. Will update the PR soon.

@gvatsal60

Copy link
Copy Markdown
Contributor Author

Samruddhi Khandale (@samruddhikhandale) I have updated the PR. Please have a look...

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change make sense to me, let's merge provided the tests are green. Thanks!

@samruddhikhandale
Samruddhi Khandale (samruddhikhandale) merged commit d231662 into devcontainers:main Oct 8, 2024
@rubensa

Copy link
Copy Markdown
Contributor

Samruddhi Khandale (@samruddhikhandale) Shouldn't this have generated a version update?

I thought that any feature change merged to main should have its corresponding version update.

NOTE: I just came here trying to check if this PR made the GitHub tags work again but, as the version was not updated, no luck to check...

@gvatsal60

Copy link
Copy Markdown
Contributor Author

Hi Ruben Suarez Alvarez (@rubensa),

I realized I forgot to update the version in the previous PR. I've submitted a new one to address this: #1148.

I’ll also look into solutions to prevent version update oversights in the future.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants