[nvidia-cuda] - Cudnn install script issue, unable to fetch latest version of libcudnn9 library - #1275
Merged
Daniel Doyle (ddoyle2017) merged 2 commits intoMar 3, 2025
Conversation
Daniel Doyle (ddoyle2017)
approved these changes
Mar 3, 2025
Daniel Doyle (ddoyle2017)
left a comment
Contributor
There was a problem hiding this comment.
As we discussed in stand-up, this approach makes sense! LGTM⚡
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref# #1270
Description: Unable to fetch the latest libcudnn9 library version for cuda 12.3 or greater versions.
Root Cause: The regular expression used for fetching latest libcudnn9 library version was incorrect as it wasn't expecting digit 1 to be present in the version number.
Changelog: Changes done in install.sh script of nvidia-cuda to correct the regular expression & also changes done in the test scripts to test the presence of latest libcudnn9 library instead of specific version when the libcudnn version isn't specified.
Checklist: