Skip to content

[Ruby] - 3.1 EOL and 3.4 addition - #1312

Merged
Daniel Doyle (ddoyle2017) merged 1 commit into
devcontainers:mainfrom
Kaniska244:Ruby_3.1_EOL
Apr 4, 2025
Merged

[Ruby] - 3.1 EOL and 3.4 addition#1312
Daniel Doyle (ddoyle2017) merged 1 commit into
devcontainers:mainfrom
Kaniska244:Ruby_3.1_EOL

Conversation

@Kaniska244

Copy link
Copy Markdown
Contributor

Ref: Issue

Description: Ruby 3.1 EOL on March 31st 2025 & Adding Ruby 3.4 available since Dec 2024 to the ruby devcontainer feature.

Changelog:

  • Change in devcontainer-feature.json to remove ruby 3.1 & add ruby 3.4
  • Change in Scenarios.json to correct the Ruby test criteria based on latest versions.
  • Change in install_additonal_ruby.sh & ruby_fallback_test.sh test scripts correct the expected ruby versions.

Checklist:

  • All changes work as expected.

@Kaniska244
Kaniska (Kaniska244) marked this pull request as ready for review March 28, 2025 09:27
@Kaniska244
Kaniska (Kaniska244) requested a review from a team as a code owner March 28, 2025 09:27

@ddoyle2017 Daniel Doyle (ddoyle2017) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! However it might probably be better to split these into separate PRs next time:

  • one for the removal of 3.1
  • one for adding 3.4

@Kaniska244

Copy link
Copy Markdown
Contributor Author

Changes look good! However it might probably be better to split these into separate PRs next time:

  • one for the removal of 3.1
  • one for adding 3.4

Hi Daniel Doyle (@ddoyle2017) ,

That did cross my mind while doing this PR. I decided otherwise because of the fact that for ruby feature both the higher & lower versions were outdated already which prompted me to update both, while doing so thought that it could be better I do it at once in the same PR so that in case of any issue with both the versions changing, it would be easy to isolate the problem.
Next time onwards I will come up separate PR's for things like this. Kindly let me know if its fine to go ahead with this PR for the time being or should I come up with separate PRs.

With Regards,
Kaniska

@ddoyle2017
Daniel Doyle (ddoyle2017) merged commit efd8832 into devcontainers:main Apr 4, 2025
@Kaniska244
Kaniska (Kaniska244) deleted the Ruby_3.1_EOL branch April 5, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants