Remove hardcoded fallback to tem from ms JDK - #1316
Merged
Christof Marti (chrmarti) merged 4 commits intoApr 7, 2025
Merged
Conversation
Kaniska (Kaniska244)
requested changes
Apr 3, 2025
Contributor
There was a problem hiding this comment.
Hi Mathiyarasy ,
The change looks good. Kindly check the below point also once.
In devcontainer-feature.json file, please bump up the version & also lets add the current Java lts version(21) in the below list of proposals.
"proposals": [
"latest",
"none",
"17",
"11",
"8"
],
Perhaps we could also add lts as a version here.
Mathiyarasy
marked this pull request as ready for review
April 3, 2025 11:26
Kaniska (Kaniska244)
approved these changes
Apr 3, 2025
Kaniska (Kaniska244)
left a comment
Kaniska (Kaniska244)
left a comment
Contributor
There was a problem hiding this comment.
Changes are fine.
Christof Marti (chrmarti)
approved these changes
Apr 4, 2025
Christof Marti (chrmarti)
left a comment
Christof Marti (chrmarti)
left a comment
Contributor
There was a problem hiding this comment.
Great, thanks!
Contributor
|
Merging to unblock other work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature Name
Description of Changes
Changelog