Skip to content

[desktop-lite] - Adding support for noVnc latest version in the feature - #1395

Merged
Álvaro Rausell Guiard (AlvaroRausell) merged 3 commits into
devcontainers:mainfrom
Kaniska244:desktop-lite-fix
Jun 27, 2025
Merged

[desktop-lite] - Adding support for noVnc latest version in the feature#1395
Álvaro Rausell Guiard (AlvaroRausell) merged 3 commits into
devcontainers:mainfrom
Kaniska244:desktop-lite-fix

Conversation

@Kaniska244

@Kaniska244 Kaniska (Kaniska244) commented Jun 23, 2025

Copy link
Copy Markdown
Contributor

Ref: #1393

Description: This PR aims to solve #1393 by adding support for latest noVnc version. All the noVnc versions post 1.2.0 are currently not working with the desktop-lite feature due to unavailability of launch.sh script which is responsible for launching the noVnc client. In these higher versions of noVnc client post 1.2.0, the client is required to be started using novnc_proxy utility. Changes are done for adding that support & also ensured that support for the older noVnc clients(<=1.2.0) remain as-is.

Changlog: The following changes are done.

  • Changed the code in install.sh to add support for noVnc client versions higher that 1.2.0
  • Updated the devcontainer-feature.json to do version bump & pining the noVncVersion property to the latest 1.6.0 version.
  • Added a test for the older versions(<=1.2.0) separately.

Checklist:

  • All checks are passed.

@Kaniska244
Kaniska (Kaniska244) marked this pull request as ready for review June 23, 2025 13:06
@Kaniska244
Kaniska (Kaniska244) requested a review from a team as a code owner June 23, 2025 13:06
@Kaniska244 Kaniska (Kaniska244) changed the title [desktop-lite] - Adding support for noVNC latest version in the feature [desktop-lite] - Adding support for noVnc latest version in the feature Jun 23, 2025
Comment thread src/desktop-lite/install.sh Outdated
Comment thread src/desktop-lite/install.sh Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants