Skip to content

python: bug fix when version = none #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Samruddhi Khandale (samruddhikhandale) merged 4 commits into from
May 16, 2022
Merged

python: bug fix when version = none #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f3226b1
python: bug fix
samruddhikhandale May 12, 2022
9059562
add missing "none" proposal
samruddhikhandale May 16, 2022
9976d57
Merge branch 'main' into samruddhikhandale/python-bug-fix
samruddhikhandale May 16, 2022
a508865
nit
samruddhikhandale May 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/docker-from-docker/feature.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"options": {
"version": {
"type": "string",
"proposals": ["latest", "20.10"],
"proposals": ["latest", "none", "20.10"],
"default": "latest",
"description": "Select or enter a Docker/Moby CLI version. (Availability can vary by OS version.)"
},
Expand Down
2 changes: 1 addition & 1 deletion src/docker-in-docker/feature.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"options": {
"version": {
"type": "string",
"proposals": ["latest", "20.10" ],
"proposals": ["latest", "none", "20.10" ],
"default": "latest",
"description": "Select or enter a Docker/Moby Engine version. (Availability can vary by OS version.)"
},
Expand Down
2 changes: 1 addition & 1 deletion src/git-lfs/feature.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"options": {
"version": {
"type": "string",
"enum": ["latest"],
"enum": ["latest", "none"],
"default": "latest",
"description": "Currently unused."
}
Expand Down
2 changes: 1 addition & 1 deletion src/github-cli/feature.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"options": {
"version": {
"type": "string",
"proposals": ["latest"],
"proposals": ["latest", "none"],
"default": "latest",
"description": "Select version of the GitHub CLI, if not latest."
}
Expand Down
2 changes: 1 addition & 1 deletion src/go/feature.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"options": {
"version": {
"type": "string",
"proposals": ["latest", "1.18", "1.17"],
"proposals": ["latest", "none", "1.18", "1.17"],
"default": "latest",
"description": "Select or enter a Go version to install"
}
Expand Down
2 changes: 1 addition & 1 deletion src/gradle/feature.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"options": {
"version": {
"type": "string",
"proposals": ["latest", "7", "6", "5"],
"proposals": ["latest", "none", "7", "6", "5"],
"default": "latest",
"description": "Select or enter a Gradle version to install"
}
Expand Down
2 changes: 1 addition & 1 deletion src/java/feature.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"options": {
"version": {
"type": "string",
"proposals": ["lts", "latest", "17", "11", "8"],
"proposals": ["lts", "latest", "none", "17", "11", "8"],
"default": "lts",
"description": "Select or enter a Java version to install"
}
Expand Down
2 changes: 1 addition & 1 deletion src/kubectl-helm-minikube/feature.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"options": {
"version": {
"type": "string",
"proposals": ["latest", "1.23", "1.22", "1.21"],
"proposals": ["latest", "none", "1.23", "1.22", "1.21"],
"default": "latest",
"description": "Select or enter a Kubernetes version to install"
},
Expand Down
2 changes: 1 addition & 1 deletion src/maven/feature.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"options": {
"version": {
"type": "string",
"proposals": ["latest", "3.8", "3.6", "3.5"],
"proposals": ["latest", "none", "3.8", "3.6", "3.5"],
"default": "latest",
"description": "Select or enter a Maven version to install"
}
Expand Down
2 changes: 1 addition & 1 deletion src/node/feature.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"options": {
"version": {
"type": "string",
"proposals": [ "lts", "latest", "18", "16", "14" ],
"proposals": [ "lts", "latest", "none", "18", "16", "14" ],
"default": "lts",
"description": "Select or enter a Node.js version to install"
},
Expand Down
2 changes: 1 addition & 1 deletion src/powershell/feature.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"options": {
"version": {
"type": "string",
"proposals": ["latest", "7.1"],
"proposals": ["latest", "none", "7.1"],
"default": "latest",
"description": "Select or enter a version of PowerShell."
}
Expand Down
1 change: 1 addition & 0 deletions src/python/feature.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
"enum": [
"latest",
"os-provided",
"none",
"3.10",
"3.9",
"3.8",
Expand Down
2 changes: 1 addition & 1 deletion src/python/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,7 @@ chown :pipx ${PIPX_HOME} ${PIPX_BIN_DIR}
chmod g+s ${PIPX_HOME} ${PIPX_BIN_DIR}

# Update pip if not using os provided python
if [ ${PYTHON_VERSION} != "os-provided" ] && [ ${PYTHON_VERSION} != "system" ]; then
if [ ${PYTHON_VERSION} != "os-provided" ] && [ ${PYTHON_VERSION} != "system" ] && [ ${PYTHON_VERSION} != "none" ]; then
echo "Updating pip..."
${PYTHON_INSTALL_PATH}/bin/python3 -m pip install --no-cache-dir --upgrade pip
fi
Expand Down
2 changes: 1 addition & 1 deletion src/ruby/feature.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"options": {
"version": {
"type": "string",
"proposals": ["latest", "3.1", "3.0", "2.7"],
"proposals": ["latest", "none", "3.1", "3.0", "2.7"],
"default": "latest",
"description": "Select or enter a Ruby version to install"
}
Expand Down
2 changes: 1 addition & 1 deletion src/rust/feature.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"options": {
"version": {
"type": "string",
"proposals": ["latest", "1.55", "1.54", "1.53"],
"proposals": ["latest", "none", "1.55", "1.54", "1.53"],
"default": "latest",
"description": "Select or enter a version of Rust to install."
},
Expand Down
1 change: 1 addition & 0 deletions src/terraform/feature.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
"type": "string",
"proposals": [
"latest",
"none",
"1.1",
"1.0",
"0.15"
Expand Down