Adding azure-linux OS support for docker-in-docker feature - #1506
Merged
Álvaro Rausell Guiard (AlvaroRausell) merged 8 commits intoDec 8, 2025
Merged
Conversation
sireeshajonnalagadda
marked this pull request as ready for review
November 3, 2025 11:21
Mathiyarasy
self-requested a review
November 4, 2025 07:03
Mathiyarasy
reviewed
Nov 17, 2025
Mathiyarasy
approved these changes
Nov 17, 2025
Sam Byng (sam-byng)
requested changes
Nov 24, 2025
Sam Byng (sam-byng)
left a comment
Sam Byng (sam-byng)
left a comment
There was a problem hiding this comment.
Hey sireeshajonnalagadda - thanks for the PR :)
In PR description:
Could you list the testing / verification that has been performed to confirm that docker-in-docker feature is still working as expected after the addition of azure-linux OS support?
In particular:
- Is install.sh working with other base image types (not just azure-linux?)
- is azure-linux working? / can we build a dev container using it with this feature?
This seems like a big change to a fundamental technology (install script for docker-in-docker) so want to make sure we're doing the right thing here.
sireeshajonnalagadda
marked this pull request as draft
November 24, 2025 12:47
Contributor
Author
|
Hi Sam Byng (@sam-byng), |
sireeshajonnalagadda
marked this pull request as ready for review
November 26, 2025 11:57
Sam Byng (sam-byng)
approved these changes
Nov 26, 2025
|
Thanks - LGTM |
Álvaro Rausell Guiard (AlvaroRausell)
merged commit Dec 8, 2025
545dbbd
into
devcontainers:main
111 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature:
Docker-in-docker
Description:
Solves issue
This is to add support of azureLinux OS for docker-in-docker feature
Changes:
Modified install script to work both ubuntu/debian and azureLinux
Created scenarios to check for both moby true and false
Checklist:
Changes worked as expected
install.sh compatibility
Confirmed that install.sh continues to work correctly with non–azure-linux base images, specifically Ubuntu and Debian.
Cross-distro testing
Ran scenarios with Ubuntu, Debian, and Mariner base images to validate docker-in-docker functionality across multiple environments.
Azure Linux support
Verified that after adding the implementation for the azure-linux distro, dev containers can be successfully built and run using docker-in-docker.