Remove duplicated CentOS 7 mirrorlist update logic - #1586
Merged
Conversation
Kaniska (Kaniska244)
requested changes
Feb 24, 2026
Kaniska (Kaniska244)
left a comment
Kaniska (Kaniska244)
left a comment
Contributor
There was a problem hiding this comment.
Hello 7006
Thank you for the contribution. Would you kindly bump the common-utils feature version?
Remove duplicated CentOS 7 mirrorlist handling introduced in this commit 52c79b4
Contributor
Author
|
@microsoft-github-policy-service agree |
Contributor
Author
|
Kaniska (Kaniska244)
approved these changes
Mar 2, 2026
Kaniska (Kaniska244)
left a comment
Kaniska (Kaniska244)
left a comment
Contributor
There was a problem hiding this comment.
Looks fine. To be further reviewed by maintainers
Abdurrahmaan Iqbal (abdurriq)
approved these changes
Mar 4, 2026
Abdurrahmaan Iqbal (abdurriq)
requested changes
Mar 4, 2026
Abdurrahmaan Iqbal (abdurriq)
left a comment
Abdurrahmaan Iqbal (abdurriq)
left a comment
Contributor
There was a problem hiding this comment.
Why should this be removed? From the commit linked in the description, it seems that it is needed in this feature to.
Abdurrahmaan Iqbal (abdurriq)
approved these changes
Mar 5, 2026
Contributor
|
Ah, I see that the block is duplicated within the file. Approved. |
Abdurrahmaan Iqbal (abdurriq)
merged commit Mar 5, 2026
0c2cd3f
into
devcontainers:main
12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove duplicated CentOS 7 mirrorlist handling introduced in this commit 52c79b4