fix(docker-in-docker): create /usr/local/share directory if it doesn't exist before writing … - #1594
Merged
Abdurrahmaan Iqbal (abdurriq) merged 1 commit intoMar 4, 2026
Conversation
Kaniska (Kaniska244)
approved these changes
Mar 4, 2026
Kaniska (Kaniska244)
left a comment
Kaniska (Kaniska244)
left a comment
Contributor
There was a problem hiding this comment.
Looks fine. To be further reviewed by maintainers.
Abdurrahmaan Iqbal (abdurriq)
approved these changes
Mar 4, 2026
Abdurrahmaan Iqbal (abdurriq)
merged commit Mar 4, 2026
065b4d4
into
devcontainers:main
111 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using a hardened images, such as https://hub.docker.com/hardened-images/catalog/dhi/debian-base the folder
/usr/local/sharedoesn't exist. This causes errors such as:This PR checks that the directory exists before creating the
/usr/local/share/docker-init.shscript.