#1635 - Fix: changed the golangci-lint script url - #1636
Merged
Abdurrahmaan Iqbal (abdurriq) merged 1 commit intoMay 5, 2026
Merged
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
Abdurrahmaan Iqbal (abdurriq)
approved these changes
May 5, 2026
Abdurrahmaan Iqbal (abdurriq)
merged commit May 5, 2026
50fd979
into
devcontainers:main
18 of 19 checks passed
Contributor
|
LGTM thank you for this fix! |
7 tasks
pull Bot
pushed a commit
to Mu-L/retina
that referenced
this pull request
May 13, 2026
…crosoft#2309) # Description The DevContainer workflow has been failing on every run since 2026-04-30 because the `ghcr.io/devcontainers/features/go:1.3.3` install script downloads `golangci-lint` v2.12.1+, which now ships an SBOM asset (`…tar.gz.sbom.json`). The deprecated `master/install.sh` greps `checksums.txt` by tarball basename, the SBOM filename matches as a prefix, and the multi-line result fails `hash_sha256_verify` — even though the actual tarball hash is correct. The fix is upstream: [devcontainers/features#1636](devcontainers/features#1636) (merged 2026-05-05) switched the Go feature's install URL to the supported `golangci-lint.run/install.sh` and bumped the feature to **`1.3.4`**. This PR bumps our pin so the next devcontainer build picks it up. Related upstream issues: [golangci/golangci-lint#6572](golangci/golangci-lint#6572), [devcontainers/features#1635](devcontainers/features#1635). ## Related Issue N/A. ## Checklist - [x] I have read the [contributing documentation](https://retina.sh/docs/Contributing/overview). - [x] I signed and signed-off the commits (`git commit -S -s ...`). - [x] I have correctly attributed the author(s) of the code. - [x] I have tested the changes locally. - [x] I have followed the project's style guidelines. - [ ] I have updated the documentation, if necessary. - [ ] I have added tests, if applicable. ## Screenshots (if applicable) or Testing Completed N/A — version-pin bump only. Will validate once the DevContainer workflow runs on this PR. ## Additional Notes N/A. Signed-off-by: Quang Nguyen <nguyenquang@microsoft.com>
Laksh (lakshk98)
pushed a commit
to lakshk98/retina
that referenced
this pull request
Aug 4, 2026
…crosoft#2309) # Description The DevContainer workflow has been failing on every run since 2026-04-30 because the `ghcr.io/devcontainers/features/go:1.3.3` install script downloads `golangci-lint` v2.12.1+, which now ships an SBOM asset (`…tar.gz.sbom.json`). The deprecated `master/install.sh` greps `checksums.txt` by tarball basename, the SBOM filename matches as a prefix, and the multi-line result fails `hash_sha256_verify` — even though the actual tarball hash is correct. The fix is upstream: [devcontainers/features#1636](devcontainers/features#1636) (merged 2026-05-05) switched the Go feature's install URL to the supported `golangci-lint.run/install.sh` and bumped the feature to **`1.3.4`**. This PR bumps our pin so the next devcontainer build picks it up. Related upstream issues: [golangci/golangci-lint#6572](golangci/golangci-lint#6572), [devcontainers/features#1635](devcontainers/features#1635). ## Related Issue N/A. ## Checklist - [x] I have read the [contributing documentation](https://retina.sh/docs/Contributing/overview). - [x] I signed and signed-off the commits (`git commit -S -s ...`). - [x] I have correctly attributed the author(s) of the code. - [x] I have tested the changes locally. - [x] I have followed the project's style guidelines. - [ ] I have updated the documentation, if necessary. - [ ] I have added tests, if applicable. ## Screenshots (if applicable) or Testing Completed N/A — version-pin bump only. Will validate once the DevContainer workflow runs on this PR. ## Additional Notes N/A. Signed-off-by: Quang Nguyen <nguyenquang@microsoft.com>
Laksh (lakshk98)
pushed a commit
to lakshk98/retina
that referenced
this pull request
Aug 4, 2026
…crosoft#2309) # Description The DevContainer workflow has been failing on every run since 2026-04-30 because the `ghcr.io/devcontainers/features/go:1.3.3` install script downloads `golangci-lint` v2.12.1+, which now ships an SBOM asset (`…tar.gz.sbom.json`). The deprecated `master/install.sh` greps `checksums.txt` by tarball basename, the SBOM filename matches as a prefix, and the multi-line result fails `hash_sha256_verify` — even though the actual tarball hash is correct. The fix is upstream: [devcontainers/features#1636](devcontainers/features#1636) (merged 2026-05-05) switched the Go feature's install URL to the supported `golangci-lint.run/install.sh` and bumped the feature to **`1.3.4`**. This PR bumps our pin so the next devcontainer build picks it up. Related upstream issues: [golangci/golangci-lint#6572](golangci/golangci-lint#6572), [devcontainers/features#1635](devcontainers/features#1635). ## Related Issue N/A. ## Checklist - [x] I have read the [contributing documentation](https://retina.sh/docs/Contributing/overview). - [x] I signed and signed-off the commits (`git commit -S -s ...`). - [x] I have correctly attributed the author(s) of the code. - [x] I have tested the changes locally. - [x] I have followed the project's style guidelines. - [ ] I have updated the documentation, if necessary. - [ ] I have added tests, if applicable. ## Screenshots (if applicable) or Testing Completed N/A — version-pin bump only. Will validate once the DevContainer workflow runs on this PR. ## Additional Notes N/A. Signed-off-by: Quang Nguyen <nguyenquang@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1635
Switches the golangci-lint install script URL from https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh to https://golangci-lint.run/install.sh, as recommended by upstream in the v2.12.1 release notes. The master branch is no longer maintained and contains a checksum-verification bug that breaks installs of v2.12.1.
Verified with
devcontainer features test -f go- passes without errors.