Skip to content

Node: Fix nvm ownership #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Samruddhi Khandale (samruddhikhandale) merged 2 commits into from
Oct 6, 2022
Merged

Node: Fix nvm ownership #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5466f15
Node: Fix nvm ownership
samruddhikhandale Oct 6, 2022
f808f91
remove 0002
samruddhikhandale Oct 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/node/devcontainer-feature.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "node",
"version": "1.0.5",
"version": "1.0.6",
"name": "Node.js (via nvm) and yarn",
"documentationURL": "https://github.com/devcontainers/features/tree/main/src/node",
"description": "Installs Node.js, nvm, yarn, and needed dependencies.",
Expand Down
4 changes: 3 additions & 1 deletion src/node/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ umask 0002
usermod -a -G nvm ${USERNAME}
mkdir -p ${NVM_DIR}
chown "${USERNAME}:nvm" ${NVM_DIR}
chmod g+s ${NVM_DIR}
chmod -R g+r+w ${NVM_DIR}
su ${USERNAME} -c "$(cat << EOF
set -e
umask 0002
Expand Down Expand Up @@ -185,4 +185,6 @@ if [ "${INSTALL_TOOLS_FOR_NODE_GYP}" = "true" ]; then
fi
fi

find "${NVM_DIR}" -type d -print0 | xargs -n 1 -0 chmod g+s
Comment thread
samruddhikhandale marked this conversation as resolved.

echo "Done!"
1 change: 1 addition & 0 deletions test/node/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ source dev-container-features-test-lib

# Definition specific tests
check "version" node --version
check "nvm" bash -c ". /usr/local/share/nvm/nvm.sh && nvm install 10"

# Report result
reportResults