Fix python feature issue #258, improve tests, fix oryx bug - #261
Merged
Conversation
Member
Author
|
/cc John Keech (@jkeech) who replied to #258 |
Member
Author
|
The Debian 9 test failed since stretch is completely out of support now and Python 3.6 is as well - so none of the tools will install in it. I'd suggest removing the test and making clear we don't support it in any feature at this point. Happy to do that in this PR if it makes sense. |
joshspicer
previously approved these changes
Nov 7, 2022
joshspicer
left a comment
joshspicer
left a comment
Member
There was a problem hiding this comment.
No comments - this looks great to me, thanks!
Member
That would be great, go for it please :) |
Samruddhi Khandale (samruddhikhandale)
previously approved these changes
Nov 7, 2022
Samruddhi Khandale (samruddhikhandale)
left a comment
Samruddhi Khandale (samruddhikhandale)
left a comment
Member
There was a problem hiding this comment.
Looks great! Thanks for fixing this and adding test coverage.
Happy to do that in this PR if it makes sense.
+1 Makes sense!
Chuck Lantz (Chuxel)
dismissed stale reviews from Samruddhi Khandale (samruddhikhandale) and joshspicer
via
November 7, 2022 18:00
f46db23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in #258, currently the "defaultInterpreterPath" is on correct in a number of cases since the code and path in the python feature was modified to support more than one version of python.
I fixed the additional python test that would have returned false positives (the
| grep ...was for the test command so it always was successful).Since the feature now manages a set of symlinks, I added test coverage for those since that was also part of the problem with os-provided... no symlink was created.
I then added one for oryx. That exposed a bug where the target folder may be missing so I fixed that.