Add Gradle and Maven version parameters to Java - #263
Conversation
6914ba6 to
a15440b
Compare
|
@microsoft-github-policy-service agree |
joshspicer
left a comment
There was a problem hiding this comment.
Thank you for taking the time to add this functionality (and adding the test). I ran the CI and the version that the scenario is trying to pass doesn't seem to exist.
------
> [dev_containers_target_stage 4/4] RUN cd /tmp/build-features/java_1 && chmod +x ./devcontainer-features-install.sh && ./devcontainer-features-install.sh:
#17 13.51 Enjoy!!!
#17 13.53 Updating /etc/bash.bashrc and /etc/zsh/zshrc...
#17 14.68 Version 18 not found. Available versions:
#17 14.68 19.0.1-open
#17 14.68 11.0.12-open
#17 14.68 11.0.2-open
#17 14.68 8.0.302-open
#17 14.68 8.0.282-open
#17 14.68 8.0.265-open
#17 14.69 ERROR: Feature "./java" (Unknown) failed to install! Look at the documentation at https://github.com/devcontainers/features/tree/main/src/java for help troubleshooting this error.
Samruddhi Khandale (samruddhikhandale)
left a comment
There was a problem hiding this comment.
Thanks for opening the PR. Left some comments.
d89ef37 to
80f70e1
Compare
|
I created a new commit that is fixing the tests that are failing in the pipeline, as mentioned here: #263 (review) |
392264e to
c3598c2
Compare
Included in the PR is a refactoring from a pipe syntax with |
270d27f to
9c4a93c
Compare
The grep with pipe syntax was creating problems with the check helper Change them in favour of process substitution syntax
Java 18 is not available anymore in SDKMAN Some tests asserts were generating false positives
9c4a93c to
907e9a6
Compare
joshspicer
left a comment
There was a problem hiding this comment.
Thank you, this looks great!
I agree, that |
closes #260