Skip to content

Features: Set USERNAME to _REMOTE_USER if available - #309

Closed
Samruddhi Khandale (samruddhikhandale) wants to merge 2 commits into
mainfrom
samruddhikhandale/fix-node-user-perm
Closed

Features: Set USERNAME to _REMOTE_USER if available#309
Samruddhi Khandale (samruddhikhandale) wants to merge 2 commits into
mainfrom
samruddhikhandale/fix-node-user-perm

Conversation

@samruddhikhandale

Copy link
Copy Markdown
Member

Helps fix #307

Comment thread src/anaconda/install.sh

@jkeech John Keech (jkeech) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add some test cases that verify the features work properly for non-standard remoteUsers?

@samruddhikhandale

Copy link
Copy Markdown
Member Author

Can you please add some test cases that verify the features work properly for non-standard remoteUsers?

For node, I tired adding a test-scenario as follows

    "test_non_root_user": {
        "image": "ubuntu:focal",
        "features": {
            "common-utils": {
                "username": "app"
            },
            "node": {
                "version": "19.1.0"
            }
        }
    }

However, even before the changes in the PR, the tests pass. The nvm folder is set with correct user permissions & node is installed fine.

image

I thought of repro-ing the scenario using dockerfile which creates this user, however the features test command doesn't support that. Need to fix that. // cc - joshspicer

image

John Keech (@jkeech) Not sure how else I could write tests 😕

@samruddhikhandale

Copy link
Copy Markdown
Member Author

Closing this in favor of #264

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Node feature permissions incorrect with custom non-root user

2 participants