Features: Set USERNAME to _REMOTE_USER if available - #309
Closed
Samruddhi Khandale (samruddhikhandale) wants to merge 2 commits into
Closed
Features: Set USERNAME to _REMOTE_USER if available#309Samruddhi Khandale (samruddhikhandale) wants to merge 2 commits into
Samruddhi Khandale (samruddhikhandale) wants to merge 2 commits into
Conversation
Samruddhi Khandale (samruddhikhandale)
requested a review
from a team
as a code owner
November 23, 2022 22:21
Member
Author
For node, I tired adding a test-scenario as follows However, even before the changes in the PR, the tests pass. The I thought of repro-ing the scenario using John Keech (@jkeech) Not sure how else I could write tests 😕 |
Member
Author
|
Closing this in favor of #264 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Helps fix #307