[PHP] Enable Mbstring - #371
Merged
Samruddhi Khandale (samruddhikhandale) merged 1 commit intoJan 4, 2023
Merged
Conversation
Julien Boudry (julien-boudry)
requested a review
from a team
as a code owner
December 31, 2022 10:57
Samruddhi Khandale (samruddhikhandale)
left a comment
Samruddhi Khandale (samruddhikhandale)
left a comment
Member
There was a problem hiding this comment.
Thanks for adding this. Left few comments.
ℹ️ The mcr.microsoft.com/devcontainers/php image also includes this extension. Nice to have the same consistency here.
Julien Boudry (julien-boudry)
force-pushed
the
patch-1
branch
from
January 3, 2023 21:32
2b77815 to
9505bc2
Compare
Contributor
Author
|
@microsoft-github-policy-service agree Samruddhi Khandale (@samruddhikhandale) I just push the test and the minor version. Hope I have done it well. |
Mbstring is such a popular PHP extension that it is used everywhere and most libraries don't work without it. It can be compiled directly with PHP. The official Docker images of PHP include it.
Julien Boudry (julien-boudry)
force-pushed
the
patch-1
branch
from
January 4, 2023 08:39
9505bc2 to
fe24e9c
Compare
Samruddhi Khandale (samruddhikhandale)
approved these changes
Jan 4, 2023
Samruddhi Khandale (samruddhikhandale)
left a comment
Samruddhi Khandale (samruddhikhandale)
left a comment
Member
There was a problem hiding this comment.
great, thanks!
ℹ️ There's a test failure which also happens on main and not an issue with this PR changes.
https://github.com/devcontainers/features/actions/runs/3836439825/jobs/6541495566
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mbstring is such a popular PHP extension that it is used everywhere and most libraries don't work without it. It can be compiled directly with PHP. The official Docker images of PHP include it.