Skip to content

Install PowerShell Modules - #427

Merged
Samruddhi Khandale (samruddhikhandale) merged 14 commits into
devcontainers:mainfrom
ross-p-smith:ross/pwsh-bicep
Jan 30, 2023
Merged

Install PowerShell Modules#427
Samruddhi Khandale (samruddhikhandale) merged 14 commits into
devcontainers:mainfrom
ross-p-smith:ross/pwsh-bicep

Conversation

@ross-p-smith

@ross-p-smith Ross Smith (ross-p-smith) commented Jan 28, 2023

Copy link
Copy Markdown
Contributor

This PR adds to the current PowerShell feature and allows the user to define a comma-separated list of Modules that installed after PowerShell is installed.

Fixes #424

@ross-p-smith
Ross Smith (ross-p-smith) requested a review from a team as a code owner January 28, 2023 00:54
@ross-p-smith Ross Smith (ross-p-smith) changed the title Install Bicep for PowerShell Install PowerShell Modules and Bicep Jan 30, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, left some comments.

Comment thread src/powershell/README.md Outdated
Comment thread src/powershell/install.sh Outdated
Comment thread src/powershell/install.sh Outdated
Comment thread src/powershell/install.sh Outdated
Co-authored-by: Samruddhi Khandale <skhandale@microsoft.com>
Co-authored-by: Samruddhi Khandale <skhandale@microsoft.com>
Comment thread src/powershell/devcontainer-feature.json Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one minor comment, but looks good otherwise!

Comment thread src/powershell/devcontainer-feature.json
@ross-p-smith Ross Smith (ross-p-smith) changed the title Install PowerShell Modules and Bicep Install PowerShell Modules Jan 30, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Powershell] Allow a list of modules to be installed

2 participants