Adds httpProxy option to Python Feature - #532
Merged
Samruddhi Khandale (samruddhikhandale) merged 3 commits intoApr 28, 2023
Merged
Conversation
This option allows GPG to use a HTTP proxy to fetch keys from remote keyservers
Contributor
Author
|
@microsoft-github-policy-service agree |
Samruddhi Khandale (samruddhikhandale)
left a comment
Samruddhi Khandale (samruddhikhandale)
left a comment
Member
There was a problem hiding this comment.
Thank you, left minor comments.
Co-authored-by: Samruddhi Khandale <samruddhikhandale@github.com>
Samruddhi Khandale (samruddhikhandale)
approved these changes
Apr 28, 2023
Samruddhi Khandale (samruddhikhandale)
left a comment
Samruddhi Khandale (samruddhikhandale)
left a comment
Member
There was a problem hiding this comment.
👏 👏
Facingreality
approved these changes
Jun 25, 2023
Facingreality
left a comment
Facingreality
left a comment
There was a problem hiding this comment.
src/python/devcontainer-feature.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This option allows GPG to use a HTTP proxy to fetch keys from remote keyservers
fixes #530
As discussed in the issue this only sets the proxy variable for GPG rather than the full feature script