Change Ruby extension to ruby-lsp - #566
Merged
Samruddhi Khandale (samruddhikhandale) merged 1 commit intoJun 29, 2023
Merged
Conversation
Rafael Mendonça França (rafaelfranca)
requested a review
from a team
as a code owner
June 5, 2023 23:21
Samruddhi Khandale (samruddhikhandale)
left a comment
Samruddhi Khandale (samruddhikhandale)
left a comment
Member
There was a problem hiding this comment.
Thank you, we appreciate your PR.
Left some thoughts!
Rafael Mendonça França (rafaelfranca)
force-pushed
the
patch-1
branch
from
June 6, 2023 00:15
0deca36 to
411be06
Compare
Samruddhi Khandale (samruddhikhandale)
requested changes
Jun 28, 2023
This is the extension that is recommended in the VSCode documentation now. https://code.visualstudio.com/docs/languages/ruby
Rafael Mendonça França (rafaelfranca)
force-pushed
the
patch-1
branch
from
June 28, 2023 20:52
411be06 to
0d6ec19
Compare
Samruddhi Khandale (samruddhikhandale)
approved these changes
Jun 28, 2023
Samruddhi Khandale (samruddhikhandale)
left a comment
Samruddhi Khandale (samruddhikhandale)
left a comment
Member
There was a problem hiding this comment.
Thank you! ✨
Samruddhi Khandale (samruddhikhandale)
enabled auto-merge (squash)
June 29, 2023 22:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the extension that is recommended in the VSCode documentation now.
https://code.visualstudio.com/docs/languages/ruby