[common-utils]: Bug fix: Install zsh on an image previously built with "installZsh:false" - #649
Merged
Samruddhi Khandale (samruddhikhandale) merged 9 commits intoSep 14, 2023
Conversation
Samruddhi Khandale (samruddhikhandale)
requested a review
from a team
as a code owner
August 11, 2023 22:56
… samruddhikhandale/common-utils-zsh-bug
Contributor
|
Please also see #653 |
… samruddhikhandale/common-utils-zsh-bug
joshspicer
approved these changes
Sep 13, 2023
joshspicer
left a comment
joshspicer
left a comment
Member
There was a problem hiding this comment.
Looks good to me! Most of this is refactor right? The important bit is that installing zsh won't be blocked if PACKAGES_ALREADY_INSTALLED?
Member
Author
joshspicer Yes, that's correct! |
Samruddhi Khandale (samruddhikhandale)
deleted the
samruddhikhandale/common-utils-zsh-bug
branch
September 14, 2023 16:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #647
Testes locally with an image provided in #647 (comment). Works as expected!
Unfortunately, I wasn't able to write a test for such a complex scenario, feedbacks on how to write a test are welcome 🙏