Skip to content

[node] Install the latest version of nvm by default - #673

Merged
Samruddhi Khandale (samruddhikhandale) merged 2 commits into
devcontainers:mainfrom
eitsupi:nvm-version
Aug 28, 2023
Merged

[node] Install the latest version of nvm by default#673
Samruddhi Khandale (samruddhikhandale) merged 2 commits into
devcontainers:mainfrom
eitsupi:nvm-version

Conversation

@eitsupi

@eitsupi eitsupi commented Aug 25, 2023

Copy link
Copy Markdown
Contributor

Close #666

@eitsupi
eitsupi requested a review from a team as a code owner August 25, 2023 14:08
@eitsupi eitsupi changed the title feat(node): install the latest nvm by default [node] Install the latest version of nvm by default Aug 25, 2023
@eitsupi

eitsupi commented Aug 26, 2023

Copy link
Copy Markdown
Contributor Author

The test failure does not seem to do with this change (#675).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! ✨

@samruddhikhandale
Samruddhi Khandale (samruddhikhandale) merged commit 95a169b into devcontainers:main Aug 28, 2023
@eitsupi
eitsupi deleted the nvm-version branch August 28, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Why not the node Feature installs the latest nvm by default?

2 participants